Make provider fully overridable by mihey8800 · Pull Request #34 · VirtoCommerce/vc-module-elastic-search-8

mihey8800 · 2025-10-23T10:10:00Z

Description

provider fully overridable. protected methods added to all public methods
implement ISupportSuggestions

References

QA-test:

Jira-link:

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.ElasticSearch8_3.823.0-pr-34-a375.zip

… public methods

vc-ci · 2025-10-23T10:10:08Z

Review task created: https://virtocommerce.atlassian.net/browse/VCST-4180

cursor · 2025-10-23T10:11:30Z

Bug: Missing Virtual Keyword in Method

The InternalAddActiveAlias method is missing the virtual keyword. This makes it non-overridable, which is inconsistent with other Internal methods and prevents derived classes from fully extending the provider as intended.

cursor · 2025-10-23T10:33:15Z

Bug: Missing Virtual Keyword in Internal Method

The InternalAddActiveAlias method is missing the virtual keyword. This makes it inconsistent with other Internal* methods and prevents overriding in subclasses, which goes against the goal of a fully overridable provider.

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.455
Timestamp: 23-10-2025T10:35:14

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.323
Timestamp: 23-10-2025T10:44:51

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.156
Timestamp: 23-10-2025T11:51:24

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.961
Timestamp: 23-10-2025T12:04:41

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.727
Timestamp: 23-10-2025T12:40:53

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.663
Timestamp: 29-10-2025T11:58:28

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.592
Timestamp: 29-10-2025T15:15:00

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.636
Timestamp: 03-11-2025T11:06:22

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.07
Timestamp: 06-11-2025T06:54:04

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.737
Timestamp: 06-11-2025T14:05:47

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.614
Timestamp: 08-11-2025T14:53:21

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.534
Timestamp: 09-11-2025T04:41:56

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.679
Timestamp: 09-11-2025T05:32:31

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.791
Timestamp: 09-11-2025T06:50:34

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.184
Timestamp: 13-11-2025T10:38:12

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.811
Timestamp: 14-11-2025T09:55:36

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.624
Timestamp: 17-11-2025T18:11:54

cursor · 2025-11-19T14:22:36Z

            appBuilder.UseSearchProvider<ElasticSearch8Provider>(ModuleConstants.ProviderName, (provider, documentTypes) =>
            {
-                provider.AddActiveAlias(documentTypes);
+                _ = provider.AddActiveAlias(documentTypes);


Bug: Async method called without awaiting in PostInitialize

The AddActiveAlias method returns a Task but is called with a discard operator without awaiting. This fire-and-forget pattern means the application initialization continues before the aliases are created, potentially causing race conditions where search operations fail because aliases haven't been set up yet. The PostInitialize method is synchronous, so either it should be made async to properly await the call, or the call should be wrapped in a synchronous wait if blocking is acceptable during initialization.

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.786
Timestamp: 19-11-2025T14:28:05

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.196
Timestamp: 21-11-2025T08:41:32

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 6.883
Timestamp: 21-11-2025T09:02:42

sonarqubecloud · 2025-11-26T12:48:12Z

Quality Gate passed

Issues
0 New issues
4 Accepted issues

Measures
0 Security Hotspots
22.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.759
Timestamp: 26-11-2025T12:57:45

vc-ci

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.87
Timestamp: 26-11-2025T13:07:56

feat: make provider fully overridable. protected methods added to all…

5be3696

… public methods

vc-ci added the review task created label Oct 23, 2025

fix sonar issue

2c4be8d

OlegoO requested a review from alexeyshibanov October 23, 2025 10:39

vc-ci reviewed Oct 23, 2025

View reviewed changes

alexeyshibanov requested changes Oct 23, 2025

View reviewed changes

mihey8800 added 2 commits October 23, 2025 14:43

virtual keyword to InternalAddActiveAlias

1c7c5f7

more proteced methods

68ebc31

vc-ci reviewed Oct 23, 2025

View reviewed changes

some protected methods remove

ab7a5fb

vc-ci reviewed Oct 23, 2025

View reviewed changes

alexeyshibanov approved these changes Oct 23, 2025

View reviewed changes

more virtual methods to provider

beb5a0e

mihey8800 requested a review from OlegoO October 29, 2025 11:56

vc-ci reviewed Oct 29, 2025

View reviewed changes

AbstractTypeFactory for SearchResponse

9c1cb07

vc-ci reviewed Oct 29, 2025

View reviewed changes

Add documentType to create index and update mapping methods

a737b16

cursor Bot reviewed Nov 3, 2025

View reviewed changes

Comment thread src/VirtoCommerce.ElasticSearch8.Data/Services/ElasticSearchResponseBuilder.cs

vc-ci reviewed Nov 3, 2025

View reviewed changes

alexeyshibanov marked this pull request as draft November 5, 2025 17:47

Add ISupportSuggestions

050d3fc

vc-ci reviewed Nov 6, 2025

View reviewed changes

Use completion contexts

36134ba

vc-ci reviewed Nov 6, 2025

View reviewed changes

vc-ci reviewed Nov 8, 2025

View reviewed changes

Sonar issues fixes

668cef8

vc-ci reviewed Nov 9, 2025

View reviewed changes

Add internal delete

228eb21

vc-ci reviewed Nov 9, 2025

View reviewed changes

Fix NRE

152ed3b

vc-ci reviewed Nov 9, 2025

View reviewed changes

alexeyshibanov marked this pull request as ready for review November 9, 2025 10:13

Return obsolete methods

653cdf8

vc-ci reviewed Nov 13, 2025

View reviewed changes

Filter contexts to avoid suggestions response deserialization issues

aadb242

vc-ci reviewed Nov 14, 2025

View reviewed changes

ksavosteev approved these changes Nov 17, 2025

View reviewed changes

Refactor GetCompletionInputs, trim punctuation symbols

544d11d

vc-ci reviewed Nov 17, 2025

View reviewed changes

chore: formatting

77d9c03

cursor Bot reviewed Nov 19, 2025

View reviewed changes

vc-ci reviewed Nov 19, 2025

View reviewed changes

alexeyshibanov added 2 commits November 21, 2025 11:31

Fix Sonar issues

3f3142c

Add ListPooledObjectPolicy

468ccf5

vc-ci reviewed Nov 21, 2025

View reviewed changes

Fix Sonar issues

68acf05

vc-ci reviewed Nov 21, 2025

View reviewed changes

ksavosteev added 2 commits November 26, 2025 14:45

chore: sonar

a7e0fcd

Merge branch 'dev' into feat/protected-provider

a375480

vc-ci reviewed Nov 26, 2025

View reviewed changes

ksavosteev merged commit 1d67412 into dev Nov 26, 2025
9 checks passed

artem-dudarev deleted the feat/protected-provider branch November 27, 2025 14:42

Conversation

mihey8800 commented Oct 23, 2025 • edited by vc-ci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

References

QA-test:

Jira-link:

Artifact URL:

Uh oh!

vc-ci commented Oct 23, 2025

Uh oh!

cursor Bot commented Oct 23, 2025

Bug: Missing Virtual Keyword in Method

Uh oh!

cursor Bot commented Oct 23, 2025

Bug: Missing Virtual Keyword in Internal Method

Uh oh!

vc-ci left a comment

Choose a reason for hiding this comment

Uh oh!

vc-ci left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vc-ci left a comment

Choose a reason for hiding this comment

Uh oh!

vc-ci left a comment

Choose a reason for hiding this comment

Uh oh!

vc-ci left a comment

Choose a reason for hiding this comment

Uh oh!

vc-ci left a comment

Choose a reason for hiding this comment

Uh oh!

vc-ci left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vc-ci left a comment

Choose a reason for hiding this comment

Uh oh!

vc-ci left a comment

Choose a reason for hiding this comment

Uh oh!

vc-ci left a comment

Choose a reason for hiding this comment

Uh oh!

vc-ci left a comment

Choose a reason for hiding this comment

Uh oh!

vc-ci left a comment

Choose a reason for hiding this comment

Uh oh!

vc-ci left a comment

Choose a reason for hiding this comment

Uh oh!

vc-ci left a comment

Choose a reason for hiding this comment

Uh oh!

vc-ci left a comment

Choose a reason for hiding this comment

Uh oh!

vc-ci left a comment

Choose a reason for hiding this comment

Uh oh!

vc-ci left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Nov 19, 2025

mihey8800 commented Oct 23, 2025 •

edited by vc-ci

Loading

sonarqubecloud Bot commented Nov 26, 2025 •

edited

Loading