fix(VCST-4390): doubled notifications#2090
Merged
ivan-kalachikov merged 2 commits intodevfrom Dec 3, 2025
Merged
Conversation
ivan-kalachikov
requested review from
Andrew-Orlov,
Copilot,
goldenmaya,
muller39 and
vas11yev1work
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes an issue where push notifications were being displayed twice (VCST-4390). The fix adds deduplication logic to prevent the same push message from being added multiple times when received via GraphQL subscription.
Key Changes:
- Added ID-based deduplication check in the subscription update handler to prevent duplicate notifications
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
yuskithedeveloper
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
References
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-4390
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/vc-theme-b2b-vue-2.36.0-pr-2090-6bd4-6bd4f165.zip