fix(VCST-4278): change language behavior#2059
Merged
ivan-kalachikov merged 3 commits intodevfrom Nov 18, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the language selection behavior to check if content exists in the target language before switching, and refactors event handling in the organization switching flow.
- Changed language selector to asynchronously fetch slug info before changing language to determine if content exists in the target language
- Added a new standalone
getSlugInfofunction for direct API calls outside of Vue composables - Changed organization switching to use
pageReloadEventinstead ofreloadAndOpenMainPage
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| client-app/shared/layout/components/language-selector/language-selector.vue | Modified language selection to be async, fetch slug info to check content availability, and conditionally set previousCultureSlug based on whether content exists in the target language |
| client-app/core/api/graphql/slugInfo/queries/getSlugInfo/index.ts | Added new getSlugInfo async function for direct API calls using graphqlClient with error handling and logging |
| client-app/shared/account/composables/useUser.ts | Changed switchOrganization to emit pageReloadEvent instead of reloadAndOpenMainPage, altering the post-switch behavior from redirecting to home to reloading the current page |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
client-app/shared/layout/components/language-selector/language-selector.vue
Show resolved
Hide resolved
client-app/core/api/graphql/slugInfo/queries/getSlugInfo/index.ts
Outdated
Show resolved
Hide resolved
client-app/shared/layout/components/language-selector/language-selector.vue
Show resolved
Hide resolved
client-app/shared/layout/components/language-selector/language-selector.vue
Show resolved
Hide resolved
client-app/core/api/graphql/slugInfo/queries/getSlugInfo/index.ts
Outdated
Show resolved
Hide resolved
client-app/shared/layout/components/language-selector/language-selector.vue
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
vas11yev1work
approved these changes
Nov 17, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
References
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-4278
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/vc-theme-b2b-vue-2.35.0-pr-2059-3256-32563244.zip