fix(VCST-4224): aborted mutations safari error notifications

[ivan-kalachikov]

Description

References

Jira-link:

https://virtocommerce.atlassian.net/browse/VCST-4224

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/vc-theme-b2b-vue-2.35.0-pr-2058-c300-c3001c63.zip

[Copilot]

Pull Request Overview

This PR fixes an issue where aborted GraphQL mutations in Safari were incorrectly triggering error notifications. The fix enhances the abort detection logic to handle Safari's specific implementation of AbortError.

• Enhanced abort error detection to recognize Safari's AbortError format by checking both the error name property and message string
• Refactored to extract abort message into a variable to avoid redundant toString() calls

Comments suppressed due to low confidence (1)

client-app/core/api/graphql/utils.ts:39

• This critical error handling function lacks test coverage. Given that:

• Other utility functions in the codebase have comprehensive test coverage (e.g., core/utilities/, core/composables/)
• This function handles important error routing logic that affects user experience
• This PR is specifically fixing a Safari-specific bug with AbortError detection

Consider adding tests to cover:

• The explicit abort reason check
• Safari's AbortError name property
• AbortError in the message string
• Regular network errors that should trigger ServerError.Unhandled
• GraphQL errors with different error codes

export function toServerError(
  networkError: NetworkError | undefined,
  graphQLErrors: ReadonlyArray<GraphQLFormattedError> | undefined,
): ServerError | undefined {
  const abortMessage = networkError?.toString() ?? "";
  const isExplicitlyAborted =
    abortMessage.includes(AbortReason.Explicit) ||
    abortMessage.includes("AbortError") ||
    networkError?.name === "AbortError";

  if ((networkError && !isExplicitlyAborted) || hasErrorCode(graphQLErrors, GraphQLErrorCode.Unhandled)) {
    return ServerError.Unhandled;
  }

  if (hasErrorCode(graphQLErrors, GraphQLErrorCode.Unauthorized)) {
    return ServerError.Unauthorized;
  }

  if (hasErrorCode(graphQLErrors, GraphQLErrorCode.Forbidden)) {
    return ServerError.Forbidden;
  }
}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud