Skip to content

Conversation

@camertron
Copy link
Contributor

See: #1958

@reeganviljoen
Copy link
Collaborator

@camertron this is also happening with other types such as json can you add a test for that

Co-authored-by: Hans Lemuet <[email protected]>
@camertron
Copy link
Contributor Author

@reeganviljoen I'm not sure a test for JSON is necessary, since html_escape({}) returns "{}" and calling #to_json on a hash or array returns a string. In all cases, escaping it should be fine if it's being emitted in an HTML context.

@camertron
Copy link
Contributor Author

PVC failures are unrelated to this change, i.e. are non-blocking 👍

@camertron camertron merged commit aca32f3 into main Jan 8, 2024
@camertron camertron deleted the fix_html_escaping_non_strings branch January 8, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants