Fix html escaping on non strings

docs/CHANGELOG.md

@@ -10,6 +10,10 @@ nav_order: 5
 
 ## main
 
+* Fix html escaping in `#call` for non strings.
+
+    *Reegan Viljoen*
+
 * Exclude html escaping of I18n reserved keys with `I18n::RESERVED_KEYS` rather than `I18n.reserved_keys_pattern`.
 
     *Nick Coyne*

lib/view_component/base.rb

@@ -309,7 +309,7 @@ def content_evaluated?
 
     def maybe_escape_html(text)
       return text if request && !request.format.html?
-      return text if text.nil? || text.empty?
+      return text if text.blank?
 
       if text.html_safe?
         text

test/sandbox/app/components/inline_slot_html_escape_component.rb

@@ -0,0 +1,18 @@
+class InlineSlotHtmlEscapeComponent < ViewComponent::Base
+  renders_one :empty_state
+
+  def initialize(counter:, heading:, url:)
+    @counter = counter
+    @heading = heading
+    @url = url
+  end
+
+  def call
+    return empty_state unless @heading.nil?
+
+    link_to @url do
+      @counter +
+        tag.p(@heading)
+    end
+  end
+end

test/sandbox/test/slotable_test.rb

@@ -752,4 +752,20 @@ def test_slot_names_can_start_with_call
       end
     end
   end
+
+  def test_inline_slot_html_escape_with_integer
+    render_inline InlineSlotHtmlEscapeComponent.new(heading: "lorem ipsum", counter: 12, url: "/some_url") do |component|
+      component.with_empty_state do
+        "empty state"
+      end
+    end
+  end
+
+  def test_inline_slot_html_escape_with_json
+    render_inline InlineSlotHtmlEscapeComponent.new(heading: "lorem ipsum", counter: {foo: "bar"}.to_json, url: "/some_url") do |component|
+      component.with_empty_state do
+        "empty state"
+      end
+    end
+  end
 end