Remove login modal overlay, force sidebar login

[jchris]

Summary

Remove the automatic login modal overlay to improve UX by forcing users to use the existing login button in the sidebar instead of showing intrusive popups.

Changes

• Removed <NeedsLoginModal /> component from app/root.tsx
• Removed unused import for NeedsLoginModal to clean up code
• Preserved all existing auth detection logic and setNeedsLogin() calls

Impact

• ✅ No more modal overlays when authentication is needed
• ✅ Sidebar login still works - users can login through the existing LoginMenu component
• ✅ All auth logic preserved - setNeedsLogin() calls continue to work (just don't trigger modal)
• ✅ All tests pass - no breaking changes to existing functionality

UX Improvement

• Before: Intrusive modal popup appears automatically when auth needed
• After: Users must intentionally click the login button in sidebar
• Benefit: Less disruptive, more user-controlled login flow

Technical Details

This is a minimal, non-breaking change:

• Only 2 lines of code removed
• All existing authentication infrastructure remains intact
• Easy to revert if needed by adding the component back
• Maintains backward compatibility

Verification

• ✅ pnpm check passes (format, typecheck, tests)
• ✅ All 68 test files pass (386 tests)
• ✅ No TypeScript errors
• ✅ Application builds and runs correctly

The change enforces that login must happen through the dedicated sidebar button, providing a cleaner and less intrusive user experience.

[netlify]

✅ Deploy Preview for fireproof-ai-builder ready!

Name	Link
🔨 Latest commit	6556452
🔍 Latest deploy log	https://app.netlify.com/projects/fireproof-ai-builder/deploys/689fa7a95d13db0008abdf8b
😎 Deploy Preview	https://deploy-preview-264--fireproof-ai-builder.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[charliecreates]

No issues detected in the modified code; the removal is clean and localized to app/root.tsx. The layout remains coherent and providers/clientside components are intact. Ensure downstream UX flows that previously relied on the modal remain discoverable via the sidebar login, but this is outside the scope of the shown diff.

Summary of changes

• Removed the NeedsLoginModal import from app/root.tsx.
• Removed the <NeedsLoginModal /> component from the Layout render tree.
• Preserved surrounding providers and components (AuthProvider, PostHogProvider, CookieConsentProvider, ClientOnly, CookieBanner, ScrollRestoration, Scripts).