Skip to content

⚡️ Optimize Base58 #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vectorized merged 1 commit into from
Jun 26, 2025
Merged

⚡️ Optimize Base58 #1442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions src/utils/Base58.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ library Base58 {
for {} lt(byte(0, mload(add(b, z))), lt(z, l)) {} { z := add(1, z) }

// Start the output offset by an over-estimate of the length.
let o := add(add(mload(0x40), 0x20), add(z, add(1, div(mul(sub(l, z), 8351), 6115))))
let o := add(add(mload(0x40), 0x21), add(z, div(mul(sub(l, z), 8351), 6115)))
let e := o

let limbs := o
Expand All @@ -44,20 +44,16 @@ library Base58 {
mstore(limbsEnd, shr(8, mload(add(b, i))))
limbsEnd := add(limbsEnd, 0x20)
}

// Use the extended scratch space for the lookup. We'll restore 0x40 later.
mstore(0x1f, "123456789ABCDEFGHJKLMNPQRSTUVWXY")
mstore(0x3f, "Zabcdefghijkmnopqrstuvwxyz")

let w := not(0) // -1.
mstore(limbsEnd, w) // Put sentinel after limbs for faster looping.
for {} 1 {} {
let i := limbs
for {} 1 {} {
if mload(i) { break }
i := add(i, 0x20)
if eq(i, limbsEnd) { break }
}
if eq(i, limbsEnd) { break }
for {} iszero(mload(i)) { i := add(i, 0x20) } {}
if iszero(not(mload(i))) { break } // Break if all limbs are zero.

let carry := 0
for { i := limbs } 1 {} {
Expand All @@ -70,10 +66,10 @@ library Base58 {
o := add(o, w)
mstore8(o, mload(carry))
}
// We probably can optimize this more by writing 32 bytes at a time.
for {} z { z := add(z, w) } {
o := add(o, w)
mstore8(o, 49) // '1' in ASCII.
let j := o
for { o := sub(o, z) } gt(j, o) {} {
j := sub(j, 0x20)
mstore(j, mul(div(w, 0xff), 49)) // '1111...1111' in ASCII.
}

let n := sub(e, o) // Compute the final length.
Expand All @@ -96,7 +92,7 @@ library Base58 {
for {} and(eq(49, byte(0, mload(add(s, z)))), lt(z, n)) {} { z := add(1, z) }

// Start the output offset by an over-estimate of the length.
let o := add(add(mload(0x40), 0x20), add(z, add(1, div(mul(sub(n, z), 7736), 10000))))
let o := add(add(mload(0x40), 0x21), add(z, div(mul(sub(n, z), 7323), 10000)))
let e := o
let limbs := o
let limbsEnd := limbs
Expand Down