Skip to content

Conversation

@Vectorized
Copy link
Owner

Description

Safe usage is left to downstream.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@github-actions
Copy link

Gas Snapshot Comparison Report

Generated at commit : 8af3593, Compared to commit : 459b53d

Contract Name Test Name Main Gas PR Gas Diff
EIP712Test testDomainSeparator() 6048 6115 67
testDomainSeparatorOnClone() 8842 8887 45
testDomainSeparatorOnCloneDynamicWithChainIdChange() 69627 69737 110
testDomainSeparatorOnCloneWithChainIdChange() 13378 13490 112
testDomainSeparatorOnDynamicWithChainIdChange() 29289 29422 133
testDomainSeparatorWithChainIdChange() 10368 10480 112
testEIP5267() 31312 31334 22
testHashTypedData() 37498 37521 23
testHashTypedDataOnClone() 40622 40690 68
testHashTypedDataOnCloneDynamic() 47284 47218 -66
testHashTypedDataOnCloneDynamicWithChaindIdChange() 59251 59271 20
testHashTypedDataOnCloneWithChaindIdChange() 50028 50118 90
testHashTypedDataOnDynamic() 45153 45174 21
testHashTypedDataOnDynamicWithChaindIdChange() 57512 57510 -2
testHashTypedDataSansChainId() 40921 40955 34
testHashTypedDataSansChainIdOnClone() 43755 43832 77
testHashTypedDataSansChainIdOnDynamic() 47613 47657 44
testHashTypedDataSansChainIdOnDynamicClone() 49501 49534 33
testHashTypedDataWithChaindIdChange() 46485 46642 157
test__codesize() 12729 15141 2412
testHashTypedDataSansChainIdAndVerifyingContract() - 40787 -
testHashTypedDataSansChainIdAndVerifyingContractOnClone() - 43771 -
testHashTypedDataSansChainIdAndVerifyingContractOnDynamic() - 47566 -
testHashTypedDataSansChainIdAndVerifyingContractOnDynamicClone() - 49440 -
testHashTypedDataSansVerifyingContract() - 40924 -
testHashTypedDataSansVerifyingContractOnClone() - 43808 -
testHashTypedDataSansVerifyingContractOnDynamic() - 47649 -
testHashTypedDataSansVerifyingContractOnDynamicClone() - 49484 -

@Vectorized Vectorized merged commit cf718ae into main Apr 29, 2025
13 checks passed
@Vectorized Vectorized deleted the more-712-sans-combos branch May 7, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants