Skip to content

feat(camera_web)!: use flutter camera platform interface #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bselwe wants to merge 2 commits into from
Closed

feat(camera_web)!: use flutter camera platform interface #1

bselwe wants to merge 2 commits into from

Conversation

@bselwe
Copy link

@bselwe bselwe commented Jul 8, 2021 •
edited
Loading

Description

  • Replaced photobooth's platform interface with the flutter camera plugin platform interface in camera_web.
  • Removed Camera class temporarily as it depends on the photobooth's platform interface.
  • The web camera plugin now throws an unimplemented error for all methods.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@bselwe bselwe added the enhancement New feature or request label Jul 8, 2021
@bselwe bselwe requested a review from felangel July 8, 2021 11:40
@bselwe bselwe self-assigned this Jul 8, 2021
@bselwe bselwe changed the title feat(camera)!: use flutter camera platform interface feat(camera_web)!: use flutter camera platform interface Jul 8, 2021
felangel
felangel reviewed Jul 8, 2021
View reviewed changes
felangel
felangel reviewed Jul 8, 2021
View reviewed changes
felangel
felangel reviewed Jul 8, 2021
View reviewed changes
@felangel felangel closed this Jul 8, 2021
@felangel felangel reopened this Jul 8, 2021
@bselwe
Copy link
Author

bselwe commented Jul 12, 2021

Moved to flutter/plugins#4151.

@bselwe bselwe closed this Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@felangel felangel felangel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bselwe bselwe

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bselwe @felangel