Fix maven thrift plugin bugs on build #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks good |
eincs
added a commit
that referenced
this pull request
Oct 11, 2013
Fix maven thrift plugin bugs on build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only v0.1.11 of maven-thrift-plugin only is on maven central. We should use v0.1.11.
And default profile should be exists for other os. (which is not mac or windows)
Developer who build Haeinsa in linux, he/she should build thrift him/herself.
See README file of maven-thrift-plugin:
https://github.com/dtrott/maven-thrift-plugin