Skip to content

ci: fix PR title check for acronyms and fork PRs#88

Merged
stevenobiajulu merged 1 commit intomainfrom
ci/fix-pr-title-and-contributing
Apr 8, 2026
Merged

ci: fix PR title check for acronyms and fork PRs#88
stevenobiajulu merged 1 commit intomainfrom
ci/fix-pr-title-and-contributing

Conversation

@stevenobiajulu
Copy link
Copy Markdown
Member

Summary

  • Switch pr-title.yml trigger from pull_request to pull_request_target so the check works on fork PRs (safe — only reads PR title, no code checkout)
  • Relax subjectPattern to allow all-caps acronyms (SHA, API, URL) while still blocking Title Case (Add, Update)
  • Add revert and build to CONTRIBUTING.md valid types list
  • Document subject casing rule and PR title enforcement

Test plan

  • PR with ci: SHA-pin something passes validation
  • PR with ci: Add something is blocked (Title Case)
  • PR with ci: API migration passes (acronym OK)
  • Fork-originated PR gets labels applied correctly

- Switch trigger from pull_request to pull_request_target so the check
  can write PR labels on fork-originated PRs (safe because this workflow
  only reads the PR title, never checks out fork code)
- Relax subjectPattern to allow all-caps acronyms (SHA, API, URL) while
  still blocking Title Case starts (Add, Update)
- Add revert and build to CONTRIBUTING.md valid types list
- Document subject casing rule and PR title enforcement in CONTRIBUTING.md
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
site Ready Ready Preview, Comment Apr 7, 2026 11:38pm

Request Review

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@stevenobiajulu stevenobiajulu merged commit ac7d94b into main Apr 8, 2026
21 checks passed
@stevenobiajulu stevenobiajulu deleted the ci/fix-pr-title-and-contributing branch April 8, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant