fix: harden linux sandbox reverse bridge startup#78
Merged
Conversation
There was a problem hiding this comment.
2 issues found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="internal/sandbox/linux.go">
<violation number="1" location="internal/sandbox/linux.go:478">
P1: The `fence_wait_for_helpers` return value is not checked, so the user command runs even when helper processes fail to start. Add `|| exit 1` (or `set -e`) so the sandbox aborts instead of running with a broken bridge.</violation>
</file>
<file name="internal/sandbox/integration_linux_test.go">
<violation number="1" location="internal/sandbox/integration_linux_test.go:484">
P2: Closing the temporary listener before initializing the reverse bridge makes this regression test race on the exposed port, so it can fail or pass against an unrelated local service.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Linux sandbox helper startup so strict sandboxing can reliably expose inbound service ports. This addresses a reverse-bridge failure that was previously masked by auto-mode fallback in downstream Tusk CLI E2E tests.
Changes
/tmp/fence/dev/null-dependent background helper startup path that was breakingsocatbridge launch inside the sandbox