ci: fix lints, disable non-determ tests #1045
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rudxain
added
refactor
Rudxain
force-pushed
the
ci/fix-lints-tests
branch
5 times, most recently
from
da0bdbb to
9f56c02
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Rudxain
force-pushed
the
ci/fix-lints-tests
branch
from
9f56c02 to
09fec11
Compare
- `exit` isn't bad for apps, only for libs - `mem_forget` is rarely a mistake, and is trivial to catch - `string_to_string` is superseded by `implicit_clone` - `allow_attributes_without_reason` can be catched by reviewers
lint regression at 26afc32
Rudxain
force-pushed
the
ci/fix-lints-tests
branch
2 times, most recently
from
0366feb to
0ee9bbf
Compare
Rudxain
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors code to improve type safety and remove unused code. The main changes focus on adding explicit lifetime parameters to Element return types, cleaning up deprecated code, and removing unused clippy lints.
Key changes:
- Added explicit lifetime parameters (
'_) toElementreturn types across view methods - Removed unused
delay_hide_copy_confirmationfunction and inlined delay logic - Removed unused
PickListenum and commented out unusedUserInfofields - Updated CI workflow to add a dedicated
cargo checkstep with warnings as errors
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/gui/widgets/package_row.rs | Added explicit lifetime to Element return type |
| src/gui/views/settings.rs | Added explicit lifetime to Element return type |
| src/gui/views/list.rs | Added explicit lifetimes, inlined delay logic, removed unused function |
| src/gui/views/about.rs | Added explicit lifetime to Element return type |
| src/gui/style.rs | Removed unused PickList enum |
| src/gui/mod.rs | Added explicit lifetime to Element return type |
| src/core/sync.rs | Replaced deprecated attribute with warning comment, changed to_string() to clone() |
| src/core/config.rs | Commented out non-deterministic tests |
| src/core/adb.rs | Commented out unused UserInfo fields and methods |
| Cargo.toml | Removed unused clippy lints and fixed indentation |
| .github/workflows/ci.yml | Added cargo check step and updated clippy configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+379
to
+383
| Command::perform( | ||
| // intentional delay | ||
| async { std::thread::sleep(std::time::Duration::from_secs(1)) }, | ||
| |()| Message::HideCopyConfirmation, | ||
| ), |
There was a problem hiding this comment.
Using std::thread::sleep inside an async block is problematic because it blocks the executor thread, preventing other async tasks from running. Replace with tokio::time::sleep or the appropriate async sleep function for your runtime to avoid blocking the async executor.
Rudxain
force-pushed
the
ci/fix-lints-tests
branch
from
0ee9bbf to
a3cc388
Compare
This reverts commit 38554ca.
Rudxain
force-pushed
the
ci/fix-lints-tests
branch
from
a3cc388 to
f9e4344
Compare
Rudxain
force-pushed
the
ci/fix-lints-tests
branch
from
f9e4344 to
15fcd10
Compare
this fixes `unused-doc-comments` lint warn
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adb_shell_commandand warn in doc-comment insteadrustcwarnings to errors, without promoting all Clippy warnings