Skip to content

Buildscript support for coreclr runtime and classlibrary building #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UnityAlex merged 4 commits into from
Nov 3, 2021
Merged

Buildscript support for coreclr runtime and classlibrary building #3

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ccc7fd7
Calling build.cmd would exit early it appears so needed to call build…
UnityAlex Oct 28, 2021
36c8648
Build script updates
UnityAlex Oct 29, 2021
e762aa9
Switching from perl to batch script to build the classlibs
UnityAlex Nov 2, 2021
f81ebe6
PR feedback: Use a function for echoing system calls
UnityAlex Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .yamato/build_classlibs_win.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: Build Classlibs Windows

agent:
type: Unity::VM
image: platform-foundation/windows-vs2019-il2cpp-bokken:stable
flavor: b1.xlarge

commands:
- .yamato/scripts/build_classlibs.bat

triggers:
pull_requests:
- targets:
only:
- "unity-main"

artifacts:
win64:
paths:
- incomingbuilds\**
6 changes: 6 additions & 0 deletions .yamato/build_windows_x64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ agent:
commands:
- .yamato/scripts/build_win.bat

triggers:
pull_requests:
- targets:
only:
- "unity-main"

artifacts:
win64:
paths:
Expand Down
20 changes: 20 additions & 0 deletions .yamato/scripts/build_classlibs.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
@echo OFF

if not exist "incomingbuilds" mkdir "incomingbuilds"

for %%x IN ("windows", "OSX", "Linux") do (
ECHO build.cmd libs -os %%x -c release
build.cmd libs -os %%x -c release
if NOT %errorlevel% == 0 (
echo "build failed"
EXIT /B %errorlevel%
)
if not exist "incomingbuilds/coreclrjit-%%x" mkdir "incomingbuilds/coreclrjit-%%x"
ECHO xcopy /s /e /h /y "artifacts/bin/runtime/net7.0-%%x-Release-x64" "incomingbuilds/coreclrjit-%%x"
xcopy /s /e /h /y "artifacts/bin/runtime/net7.0-%%x-Release-x64" "incomingbuilds/coreclrjit-%%x"
Copy link

@scott-ferguson-unity scott-ferguson-unity Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can create "functions" in batch files so we don't have to repeat these commands twice:

If you add this label to the end of the file

:EchoAndExecute
ECHO %*
CALL %*
GOTO :EOF

Then we can do

CALL :EchoAndExecute xcopy /s /e /h /y "artifacts/bin/runtime/net7.0-%%x-Release-x64" "incomingbuilds/coreclrjit-%%x"

Copy link
Collaborator Author

@UnityAlex UnityAlex Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea I'll try that

ECHO taskkill /IM "dotnet.exe" /F
taskkill /IM "dotnet.exe" /F
echo build.cmd -clean
build.cmd -clean
Copy link
Collaborator Author

@UnityAlex UnityAlex Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen this hang once if the build fails... not sure if it was a fluke or there's something wrong in here.

)
EXIT /B %ERRORLEVEL%
5 changes: 4 additions & 1 deletion .yamato/scripts/build_win.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
@echo off
build.cmd -subset clr -a x64 -c release
setlocal


powershell -ExecutionPolicy ByPass -NoProfile -Command "& 'eng\build.ps1'" -subset clr -a x64 -c release

if NOT %errorlevel% == 0 (
echo "build failed"
Expand Down