Skip to content

Conversation

@hmpf
Copy link
Contributor

@hmpf hmpf commented Mar 25, 2025

Scope and purpose

Users mentioned they wanted kiosk-version of the incident list at a recent feedback meeting. This is a doodle PR to play with some ideas.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff and djLint, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this results in changes to the database model: Updated the ER diagram

@hmpf
Copy link
Contributor Author

hmpf commented Mar 25, 2025

As I see it, the point of a kiosk mode is to remove as much as is possible of interactivity. The first commit hides filters and bulk actions.

I think we should also remove the pagination bar at the bottom and the top header. Ditto the checkbox column. I would prefer that the kiosk mode is hosted at a different url (but same view), and that there is a button to take us into and out of kiosk-mode. We could move some of the info in the pagination bar to above the incident list, like update interval and number of incidents with/without filters applied.

@hmpf hmpf moved this from 📋 Backlog to 🏗 In progress in Argus development, public Mar 25, 2025
@hmpf hmpf changed the title add tab for kiosk mode to incident menubar Add kiosk mode Mar 25, 2025
@hmpf hmpf added the enhancement New feature or request label Mar 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (0c923f0) to head (b564cf8).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1306   +/-   ##
=======================================
  Coverage   78.76%   78.76%           
=======================================
  Files         141      141           
  Lines        5763     5764    +1     
=======================================
+ Hits         4539     4540    +1     
  Misses       1224     1224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 2, 2025

@hmpf hmpf self-assigned this Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

2 participants