Fix GiniFile import of xarray FrozenDict #1204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbruick
added
Type: Bug
zbruick
force-pushed
the
xarray_update
branch
from
6a3d5a4 to
c3d850a
Compare
dopplershift
requested changes
Oct 16, 2019
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Just a minor change, otherwise good to go.
dopplershift
requested changes
Oct 16, 2019
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Just a minor change, otherwise this should be good to go.
zbruick
force-pushed
the
xarray_update
branch
from
c3d850a to
3244f6b
Compare
dopplershift
approved these changes
Oct 16, 2019
Member
|
I have no idea why it’s reporting a drop in coverage. Everything in this PR seems covered just as well as before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Adds a try/except block to support xarray v0.14 with the renaming of FrozenOrderedDict to FrozenDict. Addresses one problem in #1203.
Checklist