Exception-free API consolidated #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved
Error&to last argument spot across the board. Revisited some of the APIs that throw and moved them out of headers.There are 2 headers remaining that explicitly throw in our codebase -
json-object.handcore.hfrom math.gl. Both of these have a pretty good reason to do so, and they do it in methods that are templated. I did not go too much in depth trying to analyze how many functions that we call out to from our headers could possibly throw, as I'm not sure whether we can/should get of throw API from the 2 header files I mentioned. Let's sync over this today and I can make any updates that might make sense