Skip to content

feat: store BaseHeader height in a CSS variable #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SupaSeeka wants to merge 1 commit into
base: develop
Choose a base branch
from
+31 −1
Open

feat: store BaseHeader height in a CSS variable #675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion src/components/header/BaseHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,14 @@ import { IconButton } from '@mui/material';
import Image from 'next/image';
import Link from 'next/link';
import gradientBG from 'public/images/landingGradient.png';
import { createContext, useContext, useState, type ReactNode } from 'react';
import {
createContext,
useContext,
useEffect,
useRef,
useState,
type ReactNode,
} from 'react';
import { UTDClubsLogoStandalone } from '@src/icons/UTDClubsLogo';
import { ProfileDropDown } from './ProfileDropDown';

Expand Down Expand Up @@ -135,9 +142,32 @@ export const BaseHeader = ({

const [openCompactSearchBar, setOpenCompactSearchBar] = useState(false);

const headerRef = useRef<HTMLDivElement>(null);

Copy link
Copy Markdown
Contributor

@Isoscelestial Isoscelestial Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment here to explain what this does

Suggested change
// Dynamically stores header height into a CSS variable called `--base-header-height`.
// Useful for elements that need top offsets with `position: fixed` or `scroll-margin-top`.

useEffect(() => {
const header = headerRef.current;
if (!header) return;

const observer = new ResizeObserver(([entry]) => {
const height =
entry.borderBoxSize[0]?.blockSize ?? entry.contentRect.height;
Copy link
Copy Markdown
Contributor

@Isoscelestial Isoscelestial Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeScript complains about entry possibly being undefined, add optional chaining to entry

Suggested change
entry.borderBoxSize[0]?.blockSize ?? entry.contentRect.height;
entry?.borderBoxSize[0]?.blockSize ?? entry?.contentRect.height;

document.documentElement.style.setProperty(
'--base-header-height',
`${height}px`,
);
});

observer.observe(header);

return () => {
observer.unobserve(header);
};
}, []);

return (
<BaseHeaderContext.Provider value={{ openCompactSearchBar }}>
<div
ref={headerRef}
className={`${disableSticky ? '' : 'sticky'} min-h-17 top-0 z-50 flex w-full justify-between items-center gap-y-2 gap-x-2 md:gap-x-4 lg:gap-x-8 py-2 px-4 ${menu ? 'max-sm:pl-2' : ''} flex-wrap sm:flex-nowrap ${transparent ? '' : 'bg-lighten dark:bg-darken'} ${className}`}
>
{!transparent && (
Expand Down