-
Notifications
You must be signed in to change notification settings - Fork 24
feat: add club membership system with roles and policies #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SinhSinhAn
wants to merge
4
commits into
develop
Choose a base branch
from
feature/618-club-membership
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f8d0c0b
feat: add club membership system with roles and policies (#618)
SinhSinhAn c0c94be
fix: resolve prettier and eslint lint errors
SinhSinhAn 3d41a25
Merge branch 'develop' into feature/618-club-membership
SinhSinhAn e130b3c
fix: close membershipPolicyEnum before clubSizeEnum declaration
SinhSinhAn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
91 changes: 91 additions & 0 deletions
91
src/app/manage/[slug]/(dashboard)/(forms)/MemberSettings.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| 'use client'; | ||
|
|
||
| import { | ||
| Button, | ||
| FormControl, | ||
| InputLabel, | ||
| MenuItem, | ||
| Select, | ||
| } from '@mui/material'; | ||
| import { useMutation } from '@tanstack/react-query'; | ||
| import { useState } from 'react'; | ||
| import Panel from '@src/components/common/Panel'; | ||
| import { setSnackbar, SnackbarPresets } from '@src/components/global/Snackbar'; | ||
| import type { SelectClub } from '@src/server/db/models'; | ||
| import { useTRPC } from '@src/trpc/react'; | ||
|
|
||
| type MemberSettingsProps = { | ||
| club: SelectClub; | ||
| }; | ||
|
|
||
| const policyLabels: Record<string, string> = { | ||
| open: 'Anyone can join', | ||
| request: 'Request to join', | ||
| closed: 'No new members', | ||
| }; | ||
|
|
||
| export default function MemberSettings({ club }: MemberSettingsProps) { | ||
| const api = useTRPC(); | ||
| const [policy, setPolicy] = useState(club.membershipPolicy); | ||
|
|
||
| const updatePolicy = useMutation( | ||
| api.club.updateMembershipPolicy.mutationOptions({ | ||
| onSuccess: () => { | ||
| setSnackbar({ | ||
| message: 'Membership policy updated!', | ||
| type: 'success', | ||
| autoHideDuration: true, | ||
| fitContent: true, | ||
| closeOn: ['timeout', 'escapeKeyDown', 'dismiss'], | ||
| }); | ||
| }, | ||
| onError: (error) => { | ||
| setSnackbar( | ||
| SnackbarPresets.errorCustomMessage( | ||
| 'Failed to update membership policy', | ||
| error.message, | ||
| ), | ||
| ); | ||
| }, | ||
| }), | ||
| ); | ||
|
|
||
| const hasChanges = policy !== club.membershipPolicy; | ||
|
|
||
| return ( | ||
| <Panel heading="Member Settings"> | ||
| <div className="flex flex-col gap-4 ml-2"> | ||
| <FormControl className="max-w-xs"> | ||
| <InputLabel id="membership-policy-label"> | ||
| Membership Policy | ||
| </InputLabel> | ||
| <Select | ||
| labelId="membership-policy-label" | ||
| value={policy} | ||
| label="Membership Policy" | ||
| onChange={(e) => | ||
| setPolicy(e.target.value as 'open' | 'request' | 'closed') | ||
| } | ||
| > | ||
| {Object.entries(policyLabels).map(([value, label]) => ( | ||
| <MenuItem key={value} value={value}> | ||
| {label} | ||
| </MenuItem> | ||
| ))} | ||
| </Select> | ||
| </FormControl> | ||
| <div> | ||
| <Button | ||
| variant="contained" | ||
| className="normal-case" | ||
| disabled={!hasChanges || updatePolicy.isPending} | ||
| loading={updatePolicy.isPending} | ||
| onClick={() => updatePolicy.mutate({ clubId: club.id, policy })} | ||
| > | ||
| Save | ||
| </Button> | ||
| </div> | ||
| </div> | ||
| </Panel> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want a discard button here like on other forms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add a discard button