fix: allow editing past GCal events after unsync#661
Open
SinhSinhAn wants to merge 1 commit intodevelopfrom
Open
fix: allow editing past GCal events after unsync#661SinhSinhAn wants to merge 1 commit intodevelopfrom
SinhSinhAn wants to merge 1 commit intodevelopfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
When keepPastEvents is true during disableSync, set google=false on past events so they become editable. Also add 'google' to the conflict update columns in syncCalendar so resyncing reclaims those events.
SinhSinhAn
force-pushed
the
fix/643-allow-edit-past-gcal-events-after-unsync
branch
from
04092a9 to
b5a4617
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #643
When you unsync your Google Calendar but keep past events, those events were still locked as "Google events," so you couldn't edit or delete them. The whole point of keeping them is so you can manage them yourself.
What this PR does:
googleflag set tofalse, making them fully editable