Open
Conversation
…g, add outline when targeted
…y positioned children
…to first filters panel
…lude filter, reduce re-renders
… utils.ts comments
…unctions, improved disabled tooltip button handling
…, scroll to top when using bottom pagination
…ocation, hide location filter UI
Co-authored-by: Ethan Bickel <notethanbickel@gmail.com>
…y correct page size from query params, max query limit
…bscription buttons, update event.countByClubId procedure
…ted files to utils
TyHil
requested changes
Apr 6, 2026
Member
TyHil
left a comment
There was a problem hiding this comment.
You were not lying ab 4,000 lines of code. Did an initial look through. For me, I'll probably do some testing once we get the deployment fixed and another review off that and be good
…clubs, other requested changes
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements redesigned events directory design from Figma
Overview
/eventspageEventCardand tweaked to be more responsivefindByFilterprocedure in event routercountByClubIdprocedure in event router tocount, and updated to acceptclubIdoptionallysrc/utils/eventFilter.ts: Updated to match redesigned/eventspagesrc/utils/FilterSearchParams.ts: Wrapper class for URLSearchParams to add type safety and side effect callback functionssrc/utils/floatingActionButtons.ts: Unused utility that can hide injected floating action buttons. I kept it in case someone might find it useful, but it's technically unused so...src/utils/searchParams.ts: Utility functions and classes for safely setting URL search parameterssrc/utils/useStable.ts: Utility function to stabilize a variable; i.e. ensure a variable's reference doesn't change if an object's or array's values are deeply equivalent. This is computationally expensive and might be redundant in some places now, so I may attempt to remove this later.Tasks
findByFiltersevent API procedureeventstable, which is typed as theeventLocationFilterEnumenum ineventFilter.tsBugs
selectedFiltersis calculated (probably turn it into a store or a state) and utilizeFilterSearchParams's callback functions foronSet(),onDelete(), etc./eventspage, the tab at the top of the page doesn't get set correctly.\) and changing pages (arrow keys). Currently, these are only active when the current target is body, which is quite strict. Modify this so it's only active when an input field is not selectedPreview
URL route for following example:
/events?clubs=following&past&dateStart=2026-03-29&dateEnd=2026-05-02&tags=Academic+InterestsOld previews
URL route for following examples:`/events?hideRegistered&tags=Academic+Interests%2CEducational&dateStart=2026-03-09&dateEnd=2026-03-13&location=on-campus%2Conline&location%21=off-campusStatus update 2
Status update 1