Skip to content

54432 Keep caching off for functional tests#96

Merged
Chownder merged 9 commits intomainfrom
Keep-caching-off-for-Function-Tests
Aug 12, 2022
Merged

54432 Keep caching off for functional tests#96
Chownder merged 9 commits intomainfrom
Keep-caching-off-for-Function-Tests

Conversation

@tejasi15072
Copy link
Copy Markdown
Contributor

@tejasi15072 tejasi15072 commented Aug 12, 2022

This PR contain changes related to caching off during functional testing.

@tejasi15072 tejasi15072 requested review from a team and rockydevnet as code owners August 12, 2022 07:18
@tejasi15072 tejasi15072 changed the title 54432-Keep caching off for function tests 54432 Keep caching off for function tests Aug 12, 2022
Copy link
Copy Markdown
Collaborator

@mattwin1 mattwin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usha13529 usha13529 changed the title 54432 Keep caching off for function tests 54432 Keep caching off for functional tests Aug 12, 2022
@tejasi15072 tejasi15072 requested a review from usha13529 August 12, 2022 13:00
Copy link
Copy Markdown
Contributor

@Chownder Chownder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, even if there is another fix here not mentioned in the title (I'll include it in the merge description 🙂).

Thanks, @tejasi15072 and @ganpat-tech


return (from r in msiBannerNotificationEntityList
orderby r.StartDate ascending
orderby r.StartDate descending
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of a cheeky entry tacked in here 😄

@Chownder Chownder merged commit 60aedc4 into main Aug 12, 2022
@Chownder Chownder deleted the Keep-caching-off-for-Function-Tests branch August 12, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants