Conversation
… cache or from FSS AB#51185 AB#51101
… and retrieve the cache data that is not expiry AB#51192 AB#51101
barrie-cooper
changed the title
barrie-cooper
changed the title
usha13529
left a comment
usha13529
left a comment
There was a problem hiding this comment.
Minor comments to address please.
| { | ||
| _logger.LogInformation(EventIds.FSSDailyBatchFilesResponseStoreToCacheStart.ToEventId(), "Request for storing file share service daily NM files response in azure table storage is started for with _X-Correlation-ID:{correlationId}", correlationId); | ||
|
|
||
| await _fileShareServiceCache.InsertCacheObject(searchResult, rowKey, _cacheConfiguration.Value.FssCacheResponseTableName, frequency, correlationId); |
There was a problem hiding this comment.
Please note InsertCacheObject method is updated to support other frequency types under 51427 Cache Cumulative batches #77. This call need to update once PR77 merge into main.
There was a problem hiding this comment.
Thanks for highlighting, Yes i will do that.
usha13529
left a comment
usha13529
left a comment
There was a problem hiding this comment.
Thanks @ganpat-tech. Looks good to me.
barrie-cooper
left a comment
barrie-cooper
left a comment
There was a problem hiding this comment.
Just a couple of minor points
barrie-cooper
left a comment
barrie-cooper
left a comment
There was a problem hiding this comment.
LGTM, thanks @ganpat-tech
…https://github.com/UKHO/Maritime-Safety-Information into Feature/51425-caching-fss-response-for-daily-batches
…https://github.com/UKHO/Maritime-Safety-Information into Feature/51425-caching-fss-response-for-daily-batches
Chownder
left a comment
Chownder
left a comment
There was a problem hiding this comment.
LGTM, many thanks.
There is one comment about a potential refactoring NMDataService (quite a bit of code duplication), but given that the code itself is sound this isn't necessary.
| } | ||
|
|
||
| public async Task<List<ShowDailyFilesResponseModel>> GetDailyBatchDetailsFiles(string correlationId) | ||
| public async Task<ShowDailyFilesResponseListModel> GetDailyBatchDetailsFiles(string correlationId) |
There was a problem hiding this comment.
There's a lot of shared code between this method and GetWeeklyBatchFiles (and possibly getAllYearWeek) - this would be a good candidate for a refactor.
However, given time limits (and one more of these change due for cumulatives), possibly not the best time to start one.
barrie-cooper
left a comment
barrie-cooper
left a comment
There was a problem hiding this comment.
LGTM, thanks @ganpat-tech
barrie-cooper
deleted the
Feature/51425-caching-fss-response-for-daily-batches
branch
6 participants
Coding for daily batches
Unit Tests