Skip to content

feat: APPS-3527 change breakpoints from standard small to 850px #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2025
Merged

feat: APPS-3527 change breakpoints from standard small to 850px #858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dde7a2f
fix: change breakpoints from standard small to 850px
Oct 31, 2025
7ffa9fd
fix: 850px comment
Oct 31, 2025
ea2135e
Merge branch 'main' into APPS-3527_trigger-mobile-header-sooner
farosFreed Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/vue-component-library/src/lib-components/NavPrimary.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ defineExpose({ closeSlot })
const { width } = useWindowSize()

// Use computed to check if it's mobile based on window width
const isMobile = computed(() => width.value <= 750) // Use 750px for mobile breakpoint
const mobileBreakpoint = 850 // change scss breakpoints in ftva _header-sticky.scss, _nav-primary.scss, _site-brand-bar.scss
const isMobile = computed(() => width.value <= mobileBreakpoint) // Use 850px for mobile breakpoint

// toggle Mobile-only menu
function toggleMobileMenu() {
Expand Down
2 changes: 1 addition & 1 deletion packages/vue-component-library/src/styles/ftva/_header-sticky.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
line-height: normal;
}
}
@media #{$small} {
@media (max-width: 850px) {
.primary {
padding-inline: 18px;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/vue-component-library/src/styles/ftva/_nav-primary.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
}

// MOBILE MENU STYLES
@media #{$small} {
@media (max-width: 850px) {
display: flex;
flex-direction: column;
grid-auto-flow: unset;
Expand Down
5 changes: 4 additions & 1 deletion packages/vue-component-library/src/styles/ftva/_site-brand-bar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.ftva.site-brand-bar {
background-color: var(--ftva-off-black);
height: 110px;
height: 0px;
.ucla-text {
@include ftva-site-wordmark;
color: white;
Expand All @@ -10,4 +10,7 @@
text-transform: uppercase;
}
}
@media (min-width: 850px) {
height: 110px;
}
}