-
Notifications
You must be signed in to change notification settings - Fork 5
feat: Creates FilterDropdown and RefineSearchPanel #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- marks footer as already existing
| options: string[] | ||
| } | ||
| const { filterGroups } = defineProps({ | ||
| const { filterGroups, limitOptions } = defineProps({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this file
| type: Array as PropType<FilterGroupsTypes[]>, | ||
| default: () => [], | ||
| }, | ||
| limitOptions: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert this change
| }) | ||
| // Limit options for each filter group if limitOptions is true | ||
| const limitedFilterGroups = computed(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this change
| @@ -0,0 +1,252 @@ | |||
| <script setup lang="ts"> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename this component to FilterSelections
| title: string | ||
| filters: Array<{ | ||
| name: string | ||
| slotName: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a new key facetField, which is the name of the filter in Elastic Search that needs to be searched on, to the filters object, example: for Subject Filter , the facetField could be subject_tesim or something like that.
| else { | ||
| // Add option | ||
| currentSelection.push(option.value) | ||
| emit('option-selected', filterName, option) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
along with emitting the event we also want to push the router with new query paramaeters when option is selected or deselected and pagination parameter is reset in the query.
…via the arrow inputs - adjusts the spec.js file - adjusts the component and its css to make room for the min/max slider handles when they are very close next to each other,
- reverts the limiting feature of the filers-dropdown - updates the stoires for the also updates year-range-filter - adds the filter prefixes - renames the component and it's files..
Component Created: FilterDropdown.vue
Component Created: RefineSearchPanel.vue
Component Created: EffectSlideToggle.vue
Stories: ~/stories/FilterDropdown.stories.js
Stories: ~/stories/RefineSearchPanel.stories.js
Stories: ~/stories/EffectSlideToggle.stories.js
Spec: ~/stories/FilterDropdownspec.js
Spec: ~/stories/RefineSearchPanel.js
Spec: ~/stories/EffectSlideToggle.js
Notes:




Checklist:
library-website-nuxt dev server