feat: create YearRangeFilter component #844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- marks footer as already existing
pghorpade
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
github-actions
bot
temporarily deployed
to
storybook--pull_request_target-844
pghorpade
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
github-actions
bot
temporarily deployed
to
storybook--pull_request_target-844
pghorpade
requested changes
Oct 27, 2025
|
|
||
| // Handle limit button click | ||
| function handleLimitClick() { | ||
| emit('change', { min: localMinValue.value, max: localMaxValue.value }) |
There was a problem hiding this comment.
Router integration on “Limit”
- Use useRoute() + useRouter() and push a new query while preserving existing ones.
- Avoid clobbering other query params; just set year_gte / year_lte (or names you pass via props).
- Optionally clear pagination (page) when filters change.
| step: number | ||
| disabled: boolean | ||
| } | ||
| const props = defineProps<YearRangeFilterProps>() |
There was a problem hiding this comment.
Configurable query param names
- Add optional props like minParam / maxParam so this component stays reusable across pages.
pghorpade
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
github-actions
bot
temporarily deployed
to
storybook--pull_request_target-844
pghorpade
requested changes
Oct 29, 2025
| <YearRangeFilter v-bind="args" /> | ||
| <div style="margin-top: 20px; padding: 10px; background: #f5f5f5; border-radius: 4px;"> | ||
| <h4 style="margin: 0 0 10px 0;">Mock Query Parameters:</h4> | ||
| <pre style="margin: 0; font-size: 12px;">{{ JSON.stringify(mockQuery, null, 2) }}</pre> |
There was a problem hiding this comment.
what should this output?
…via the arrow inputs - adjusts the spec.js file - adjusts the component and its css to make room for the min/max slider handles when they are very close next to each other,
github-actions
bot
temporarily deployed
to
storybook--pull_request_target-844
pghorpade
requested changes
Oct 30, 2025
| @@ -0,0 +1,11 @@ | |||
| Designs: | |||
| }, | ||
| setup() { | ||
| // Mock router for Storybook demonstration | ||
| return { args } |
There was a problem hiding this comment.
// reactively read the router query
const currentQuery = computed(() => router.currentRoute.value.query)
// make a canonical querystring to display (sorted for stability)
const queryString = computed(() => {
const params = new URLSearchParams()
// sort keys for consistent output
const entries = Object.entries(currentQuery.value).sort(([a], [b]) => a.localeCompare(b))
for (const [key, val] of entries) {
if (Array.isArray(val)) {
for (const v of val) params.append(key, String(v))
} else if (val != null) {
params.set(key, String(val))
}
}
const s = params.toString()
return s ? `?${s}` : ''
})
return { args, currentQuery, queryString }
| template: ` | ||
| <div style="width: 280px;"> | ||
| <YearRangeFilter v-bind="args" /> | ||
| </div> |
There was a problem hiding this comment.
<!-- Debug panel that updates the moment the Limit button pushes to router -->
<div style="font-family: ui-monospace, SFMono-Regular, Menlo, monospace; font-size: 12px; border: 1px solid #eee; border-radius: 8px; padding: 8px;">
<div style="margin-bottom: 6px;"><strong>Router querystring</strong></div>
<div style="padding: 6px 8px; background: #fafafa; border-radius: 6px; overflow:auto;">
{{ queryString }}
</div>
<div style="margin: 8px 0 6px;"><strong>Router query (JSON)</strong></div>
<pre style="margin: 0; white-space: pre-wrap;">{{ currentQuery }}</pre>
</div>
There was a problem hiding this comment.
try these changes and see if we can output the router querychanges
pghorpade
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
pghorpade
pushed a commit
that referenced
this pull request
Nov 3, 2025
# [@ucla-library-monorepo/ucla-library-website-components-v1.42.0](https://github.com/UCLALibrary/ucla-library-website-components/compare/@ucla-library-monorepo/ucla-library-website-components-v1.41.3...@ucla-library-monorepo/ucla-library-website-components-v1.42.0) (2025-11-03) ### Features * create YearRangeFilter component ([#844](#844)) ([0d1c1f4](0d1c1f4))
|
🎉 This PR is included in version @ucla-library-monorepo/ucla-library-website-components-v1.42.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component Created: YearRangeFilter.vue
Stories: ~/stories/YearRangeFilter.stories.js
Spec: ~/stories/YearRangeFilter.spec.js
Notes:
Designs: https://www.figma.com/design/CDhWDARLb36ftkQce1LyLC/Breakpoints?node-id=1-25&m=dev
https://www.figma.com/design/CDhWDARLb36ftkQce1LyLC/Breakpoints?node-id=1-26&p=f&m=dev
Read in Recording: https://drive.google.com/file/d/17tiGmE4aax-faoo5Rjue2Idbx3OGCFGa/view?usp=sharing
Relevant Links https://www.library.ucla.edu/ https://digital.library.ucla.edu/catalog/ark:/21198/z1x98m6j
Checklist:
library-website-nuxt dev server