Skip to content

Conversation

@Sveb
Copy link
Collaborator

@Sveb Sveb commented Sep 2, 2025

Component Created: ExcerptPod.vue

Stories: ~/stories/ExcerptPod.stories.js

Spec: ~/stories/ExcerptPod.spec.js

Notes:
Screenshot 2025-11-04 at 08 19 41

Screenshot 2025-11-04 at 08 19 49

Checklist:

  • I checked that it is working locally in the dev server
  • I checked that it is working locally in the storybook
  • I checked that it is working locally in the
    library-website-nuxt dev server
  • I added a screenshot of it working
  • UX has reviewed and approved this
  • I assigned this PR to someone on the dev team to review
  • I used a conventional commit message
  • I assigned myself to this PR

@Sveb Sveb changed the title feat: creates ExcerptPod w/ NotesAccordion feat: creates ExcerptPod w/ NotesAccordion components Sep 2, 2025
@pghorpade
Copy link
Contributor

@lux-v or @Sveb I have question for design team , we have the following existing pages where we show metadata
https://digital.library.ucla.edu/catalog/ark:/21198/z15q6d4q
https://digital.library.ucla.edu/catalog/ark:/21198/zz0002np7z

What kind of metadata are we showing in this component ?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025

@github-actions github-actions bot temporarily deployed to storybook--pull_request_target-804 October 20, 2025 23:47 Inactive
@pghorpade
Copy link
Contributor

@Sveb I deployed it to storybook, I dont think the prop data structure will work with the data I have seen on Digital Library pages. We have key value pairs for all the metadata like description is the key and This digital collection is comprised of selected digitized photographic negatives from the analog photographic archive. Digitization and description of this collection is ongoing. The analog collection consists of photonegatives documenting events and people in Southern California and photographic prints documenting events and people in Southern California, the U.S., and the world. The material originates from the Los Angeles Times newspaper and includes glass negatives (ca. 1918-1932), nitrate negatives (ca. 1925-45), and safety negatives (ca. 1935-present). Also includes prints and negatives from the Los Angeles Times Orange County and San Diego bureaus. is an exmple of value that comes from elastic search. So how would you break apart the value data so part of it is the text in ExcerptPod and the rest is in Accordion component.

@Sveb Sveb temporarily deployed to netlify-preview October 24, 2025 09:55 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request_target-804 October 24, 2025 18:35 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request_target-804 October 31, 2025 21:54 Inactive
pghorpade
pghorpade previously approved these changes Oct 31, 2025
Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Sveb Sveb temporarily deployed to netlify-preview November 3, 2025 06:38 — with GitHub Actions Inactive
@Sveb Sveb changed the title feat: creates ExcerptPod w/ NotesAccordion components feat: creates ExcerptPod component Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants