Skip to content

Conversation

@Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Oct 3, 2025

No description provided.

… exceptions instead of `VideoUnavailableException`
Copilot AI review requested due to automatic review settings October 3, 2025 23:17
@Tyrrrz Tyrrrz added the bug label Oct 3, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes tests for language-specific streams by updating expected language names and improving error handling in the stream client. The changes address test failures likely caused by changes in YouTube's language name formatting.

  • Updated expected language names in tests to match current YouTube API responses
  • Enhanced exception handling to only retry on specific video unplayability scenarios
  • Improved code organization by moving a comment to a more logical position

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
YoutubeExplode/Videos/Streams/StreamClient.cs Enhanced exception handling to filter retry logic and reorganized comments
YoutubeExplode.Tests/StreamSpecs.cs Updated expected language names from full country names to abbreviated formats

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Tyrrrz Tyrrrz changed the title Fix tests for language-specific streams Fix fetching unavailable (deleted, private) videos throwing unrelated exceptions instead of VideoUnavailableException Oct 3, 2025
@Tyrrrz Tyrrrz closed this Oct 3, 2025
@Tyrrrz Tyrrrz reopened this Oct 3, 2025
@Tyrrrz Tyrrrz merged commit d1e6119 into master Oct 3, 2025
10 checks passed
@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (dad9248) to head (7679871).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@      Coverage Diff      @@
##   master   #912   +/-   ##
=============================
=============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants