-
-
Notifications
You must be signed in to change notification settings - Fork 5
Add polyfills for File.WriteAll*Async(...), File.ReadAll*Async(...), and File.AppendAll*Async(...)
#40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…)`, and `File.AppendAll*Async(...)`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds polyfills for asynchronous File I/O methods to support older .NET frameworks that lack these APIs. The implementation provides compatibility for WriteAllAsync, ReadAllAsync, and AppendAllAsync methods across different data types (bytes, text, and lines).
Key changes:
- Added NetCore20 polyfills for File async methods (Write/Read/AppendAll for bytes/text/lines)
- Added Net90 polyfill for
AppendAllBytesAsync - Comprehensive test coverage for all polyfilled methods
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 22 comments.
| File | Description |
|---|---|
| PolyShim/NetCore20/File.cs | Implements 12 async File I/O methods as polyfills for .NET Core 2.0 and earlier frameworks |
| PolyShim/Net90/File.cs | Implements AppendAllBytesAsync polyfill for .NET 9.0 and earlier frameworks |
| PolyShim.Tests/NetCore20/FileTests.cs | Provides test coverage for all 8 main NetCore20 File polyfill methods |
| PolyShim.Tests/Net90/FileTests.cs | Provides test coverage for the Net90 AppendAllBytesAsync polyfill |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
…to file-write-read-append-async
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.