Skip to content

Conversation

@Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Nov 16, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 16, 2025 17:25
@Tyrrrz Tyrrrz added the enhancement New feature or request label Nov 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds polyfills for asynchronous File I/O methods to support older .NET frameworks that lack these APIs. The implementation provides compatibility for WriteAllAsync, ReadAllAsync, and AppendAllAsync methods across different data types (bytes, text, and lines).

Key changes:

  • Added NetCore20 polyfills for File async methods (Write/Read/AppendAll for bytes/text/lines)
  • Added Net90 polyfill for AppendAllBytesAsync
  • Comprehensive test coverage for all polyfilled methods

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 22 comments.

File Description
PolyShim/NetCore20/File.cs Implements 12 async File I/O methods as polyfills for .NET Core 2.0 and earlier frameworks
PolyShim/Net90/File.cs Implements AppendAllBytesAsync polyfill for .NET 9.0 and earlier frameworks
PolyShim.Tests/NetCore20/FileTests.cs Provides test coverage for all 8 main NetCore20 File polyfill methods
PolyShim.Tests/Net90/FileTests.cs Provides test coverage for the Net90 AppendAllBytesAsync polyfill

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tyrrrz Tyrrrz merged commit 804837c into master Nov 16, 2025
11 checks passed
@Tyrrrz Tyrrrz deleted the file-write-read-append-async branch November 16, 2025 17:43
@codecov
Copy link

codecov bot commented Nov 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (c3d1446) to head (de56186).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@     Coverage Diff      @@
##   master   #40   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants