Skip to content

Conversation

@piecyk
Copy link
Contributor

@piecyk piecyk commented Feb 4, 2022

I agree that logger options where overcomplicated, and good that it was simplified in #695 but still having an option to use webpack infrastructure logger would be nice, matching other plugins.

Maybe we can meet in the middle, this PR just use already provided infrastructure-logger enabling it via webpack-infrastructure option, imho this should be the default 😉

@piotr-oles
Copy link
Collaborator

You can configure webpack to show infrastructure logs for the plugin:

  infrastructureLogging: {
    level: 'log',
    debug: /ForkTsCheckerWebpackPlugin/,
  },

Does this solve your issue?

@piecyk
Copy link
Contributor Author

piecyk commented Feb 5, 2022

You can configure webpack to show infrastructure logs for the plugin:

Yes, but i'm not interested in those logs when writing code.

Does this solve your issue?

No, as it still will print via console, overall i want everything being logged via webpack infrastructure logger, making the output consistent.

@piotr-oles
Copy link
Collaborator

So basically you want to have a [ForkTsCheckerWebpackPlugin] prefix for all logs, even those that report type-checking errors, right?

@piecyk
Copy link
Contributor Author

piecyk commented Feb 6, 2022

Yes, keeping the formatting consistent, but here it's not only about the prefix it will also queue the messages correctly, checkout the https://github.com/webpack/webpack/blob/main/lib/node/nodeConsole.js

@piecyk piecyk force-pushed the feature/webpack-infrastructure-logger branch from b72a89c to 2fd54e3 Compare February 7, 2022 04:09
Copy link
Collaborator

@piotr-oles piotr-oles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems legit, I will test it manually and if everything is good, we can merge this

@piecyk
Copy link
Contributor Author

piecyk commented Feb 7, 2022

Thanks 🙌

@piotr-oles piotr-oles merged commit a6b66eb into TypeStrong:main Feb 8, 2022
@piotr-oles
Copy link
Collaborator

🎉 This PR is included in version 7.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants