Skip to content

fix: require typescript@^3.8.0 for build: true mode #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piotr-oles merged 1 commit into from
Oct 24, 2021
Merged

fix: require typescript@^3.8.0 for build: true mode #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/typescript-reporter/TypeScriptSupport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ function assertTypeScriptSupport(configuration: TypeScriptReporterConfiguration)
].join(os.EOL)
);
}
if (configuration.build && semver.lt(typescriptVersion, '3.8.0')) {
throw new Error(
[
`ForkTsCheckerWebpackPlugin doesn't support build option for the current typescript version of ${typescriptVersion}.`,
'The minimum required version is 3.8.0.',
].join(os.EOL)
);
}

if (!fs.existsSync(configuration.configFile)) {
throw new Error(
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/TypeScriptSolutionBuilderApi.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import semver from 'semver';

describe('TypeScript SolutionBuilder API', () => {
it.each([
{ async: false, typescript: '~3.6.0', mode: 'readonly' },
{ async: false, typescript: '~3.8.0', mode: 'readonly' },
{ async: true, typescript: '~3.8.0', mode: 'write-tsbuildinfo' },
{ async: false, typescript: '~4.0.0', mode: 'write-references' },
{ async: true, typescript: '~4.3.0', mode: 'readonly' },
Expand Down