feat: add support for "generateTrace" tsconfig option #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import { createPerformance } from '../../profile/Performance'; | ||
| import { connectTypeScriptPerformance } from '../profile/TypeScriptPerformance'; | ||
|
|
||
| // write this type as it's available only in the newest TypeScript versions (^4.1.0) |
Member
There was a problem hiding this comment.
So when typescript 4.1 ships we can lose this?
Collaborator
Author
There was a problem hiding this comment.
We would have to upgrade typescript in dev dependencies, and then probably this type will be available (if it will be in the public API)
johnnyreilly
approved these changes
Oct 24, 2020
Collaborator
Author
|
🎉 This PR is included in version 6.0.0-alpha.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
Author
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #453 (comment)
Related TypeScript's PR: microsoft/TypeScript#40063