Skip to content

[TD-2193] Use correct tags for CI push and CI test#5465

Merged
alephnull merged 5 commits into
masterfrom
ci/fix-tags
Aug 25, 2023
Merged

[TD-2193] Use correct tags for CI push and CI test#5465
alephnull merged 5 commits into
masterfrom
ci/fix-tags

Conversation

@alephnull
Copy link
Copy Markdown
Contributor

@alephnull alephnull commented Aug 25, 2023

The old architecture of doing ci in a separate job made the larger workflow seemingly more resilient but as the automation grows, failures in CI will make the remainder of the release process unprocessable. So doubling down on making CI push robust.

Removed ci/auto as it lives in tyk-ci now. Tested by re-using v5.2.1-alpha.

I will propagate this fix to gw and dash master and lts branches via templates, the fix will have to be cherry picked for other branches where it is required. Please review https://github.com/TykTechnologies/tyk-analytics/pull/3429 along with this one.

Removed ci/auto as it lives in tyk-ci now
@alephnull alephnull requested a review from a team as a code owner August 25, 2023 02:25
@alephnull alephnull marked this pull request as draft August 25, 2023 02:25
@github-actions
Copy link
Copy Markdown
Contributor

PR Analysis

  • 🎯 Main theme: Updating the CI/CD pipeline to use correct tags for CI push and CI test
  • 📌 Type of PR: Refactoring
  • Focused PR: Yes, all changes are related to the CI/CD pipeline and tagging.
  • 🔒 Security concerns: No security concerns found

PR Feedback

  • General suggestions: The changes in this PR seem to be well thought out and are a good step towards improving the CI/CD pipeline. However, it would be beneficial to add some tests to ensure the changes work as expected.

  • 🤖 Code feedback:

    • relevant file: .github/workflows/release.yml
      suggestion: Consider using a script file to handle the complex logic in the 'run' section. This will make the code more readable and maintainable. [medium]
      relevant line: run: |

    • relevant file: .github/workflows/release.yml
      suggestion: It's a good practice to avoid hardcoding values like 'amd64' and 'arm64'. Consider using environment variables or configuration files to store these values. [medium]
      relevant line: for arch in amd64 arm64; do

    • relevant file: .github/workflows/release.yml
      suggestion: It's recommended to handle errors in the script. The 'set +e' command prevents the script from exiting when a command fails. This could lead to unexpected behavior. [important]
      relevant line: set +e

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

@github-actions
Copy link
Copy Markdown
Contributor

API Changes

no api changes detected

@Tyk-ITS
Copy link
Copy Markdown
Contributor

Tyk-ITS commented Aug 25, 2023

API tests result: success
Branch used: refs/pull/5465/merge
Commit:
Triggered by: pull_request (@alephnull)
Execution page

@Tyk-ITS
Copy link
Copy Markdown
Contributor

Tyk-ITS commented Aug 25, 2023

API tests result: success
Branch used: refs/pull/5465/merge
Commit: f406dcc
Triggered by: pull_request (@alephnull)
Execution page

@Tyk-ITS
Copy link
Copy Markdown
Contributor

Tyk-ITS commented Aug 25, 2023

API tests result: failure 🚫
Branch used: refs/pull/5465/merge
Commit: 96ae1ad
Triggered by: pull_request (@alephnull)
Execution page

@Tyk-ITS
Copy link
Copy Markdown
Contributor

Tyk-ITS commented Aug 25, 2023

API tests result: success
Branch used: refs/pull/5465/merge
Commit: e1951a3
Triggered by: pull_request (@alephnull)
Execution page

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Tyk-ITS
Copy link
Copy Markdown
Contributor

Tyk-ITS commented Aug 25, 2023

API tests result: success
Branch used: refs/pull/5465/merge
Commit: 191404f
Triggered by: pull_request (@alephnull)
Execution page

@alephnull alephnull marked this pull request as ready for review August 25, 2023 04:00
@alephnull alephnull requested a review from titpetric August 25, 2023 04:00
@alephnull alephnull enabled auto-merge (squash) August 25, 2023 04:28
@alephnull alephnull merged commit 2c41525 into master Aug 25, 2023
@alephnull alephnull deleted the ci/fix-tags branch August 25, 2023 13:51
@asutosh
Copy link
Copy Markdown
Contributor

asutosh commented Sep 27, 2023

/release to release-5.2.1

@tykbot
Copy link
Copy Markdown

tykbot Bot commented Sep 27, 2023

Working on it! Note that it can take a few minutes.

tykbot Bot pushed a commit that referenced this pull request Sep 27, 2023
The old architecture of doing ci in a separate job made the larger
workflow seemingly more resilient but as the automation grows, failures
in CI will make the remainder of the release process unprocessable. So
doubling down on making CI push robust.

Removed ci/auto as it lives in tyk-ci now. Tested by re-using
[v5.2.1-alpha](https://github.com/TykTechnologies/tyk/actions/runs/5971645065).

(cherry picked from commit 2c41525)
@tykbot
Copy link
Copy Markdown

tykbot Bot commented Sep 27, 2023

@asutosh Succesfully merged PR

buger added a commit that referenced this pull request Sep 27, 2023
…CI test (#5465)

[TD-2193] Use correct tags for CI push and CI test (#5465)

The old architecture of doing ci in a separate job made the larger
workflow seemingly more resilient but as the automation grows, failures
in CI will make the remainder of the release process unprocessable. So
doubling down on making CI push robust.

Removed ci/auto as it lives in tyk-ci now. Tested by re-using
[v5.2.1-alpha](https://github.com/TykTechnologies/tyk/actions/runs/5971645065).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants