Change private Url setter to protected #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for clean inheritance for DI use
Turnerj
approved these changes
Oct 31, 2020
Member
|
Done - 0.23.1 should be going to NuGet shortly. |
Contributor
Author
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for clean inheritance for DI use
Creating a MongoDbConnection that will take a tenant by DI and use its connection string. I'd rather be able to inherit from the existing MongoDbConnection than copy the whole class for this project.
If its OK with you, would you merge and update NuGet with a tiny release 0.23.1 perhaps?