Skip to content

CompatHelper: bump compat for OptimizationOptimJL to 0.4 for package test, (keep existing compat)#2353

Closed
github-actions[bot] wants to merge 1 commit intomasterfrom
compathelper/new_version/2024-09-27-00-32-07-932-02699879800
Closed

CompatHelper: bump compat for OptimizationOptimJL to 0.4 for package test, (keep existing compat)#2353
github-actions[bot] wants to merge 1 commit intomasterfrom
compathelper/new_version/2024-09-27-00-32-07-932-02699879800

Conversation

@github-actions
Copy link
Contributor

This pull request changes the compat entry for the OptimizationOptimJL package from 0.1, 0.2, 0.3 to 0.1, 0.2, 0.3, 0.4 for package test.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@penelopeysm penelopeysm force-pushed the compathelper/new_version/2024-09-27-00-32-07-932-02699879800 branch from 622e056 to 92ec34d Compare September 27, 2024 00:32
@codecov
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.80%. Comparing base (3c91eec) to head (92ec34d).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2353      +/-   ##
==========================================
- Coverage   86.86%   86.80%   -0.07%     
==========================================
  Files          24       24              
  Lines        1599     1599              
==========================================
- Hits         1389     1388       -1     
- Misses        210      211       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yebai
Copy link
Member

yebai commented Sep 27, 2024

Is there a way to open an aggregated PR for these dependencies upgrades? If not, we could contribute a feature to CompatHelper.

@penelopeysm @devmotion any thoughts?

@penelopeysm
Copy link
Member

penelopeysm commented Sep 27, 2024

That thought has struck me, but I think it's impossible for an automated tool to figure out which of the PRs are related and should be aggregated. Although grouping multiple PRs into one is fairly easy (create a new branch -> merge PRs into that branch -> open a new PR from that branch back to master), the converse problem of breaking up a PR is actually more annoying to deal with (git reset HEAD~ -> git add -p which often isn't granular enough -> reopen PRs) so we wouldn't want that either.

The closest compromise I can think of is if the same dependency is being bumped in the main package + tests, then group those. That could be an optional flag for CompatHelper.main()

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11062381193

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 87.022%

Totals Coverage Status
Change from base Build 11050401755: -0.06%
Covered Lines: 1388
Relevant Lines: 1595

💛 - Coveralls

@yebai yebai deleted the compathelper/new_version/2024-09-27-00-32-07-932-02699879800 branch October 24, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants