Skip to content

Remove incorrect mapvcat Zygote adjoint #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yebai merged 3 commits into from
Jan 15, 2025
Merged

Remove incorrect mapvcat Zygote adjoint #362

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73f3459
Remove mapvcat Zygote manual adjoint
mhauru Jan 14, 2025
4946dbf
Add test for Stacked with vectors
mhauru Jan 14, 2025
7d2c9c7
Bump patch version to 0.15.4
mhauru Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ext/BijectorsZygoteExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ using Bijectors:
find_alpha,
pd_logpdf_with_trans,
istraining,
mapvcat,
eachcolmaphcat,
sumeachcol,
pd_link,
Expand All @@ -36,10 +35,6 @@ using Bijectors.Distributions: LocationScale

@adjoint istraining() = true, _ -> nothing

@adjoint function mapvcat(f, args...)
g(f, args...) = map(f, args...)
return pullback(g, f, args...)
end
@adjoint function eachcolmaphcat(f, x1, x2)
function g(f, x1, x2)
init = reshape(f(view(x1, :, 1), x2[1]), :, 1)
Expand Down
11 changes: 11 additions & 0 deletions test/ad/stacked.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,15 @@
test_ad(y) do y
sum(transform(binv, y))
end

bvec = Stacked([b1, b2], [1:4, 5:5])
bvec_inv = inverse(bvec)

test_ad(y) do x
sum(transform(bvec, binv(x)))
end

test_ad(y) do y
sum(transform(bvec_inv, y))
end
end
Loading