Skip to content

Using Setfield.jl's lenses to handle indexing #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yebai merged 43 commits into from
Aug 20, 2021
Merged

Using Setfield.jl's lenses to handle indexing #26

Show file tree
Hide file tree
Changes from 41 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
1e267f8
allowed use of Setfield.lens in VarName
torfjelde May 18, 2021
286e211
implemented subsumes for lenses
torfjelde May 18, 2021
eb65b76
varname macro now uses lenses by default
torfjelde May 18, 2021
e8058a4
Merge branch 'main' into tor/lenses
torfjelde Jul 26, 2021
b72243a
added concretize method for instantiating a variable on a particular …
torfjelde Jul 27, 2021
122092d
added some type-piracy because its a free world
torfjelde Jul 27, 2021
29e051b
fixed and added doctests
torfjelde Jul 27, 2021
6092b7c
fixed varname
torfjelde Jul 29, 2021
2259b30
fixed varname doctest
torfjelde Jul 29, 2021
298e1fc
allow specifying whether we want to concretize or not in varname
torfjelde Jul 29, 2021
9dd6cf7
need to escape indices
torfjelde Jul 29, 2021
b94bcce
fixed show
torfjelde Jul 29, 2021
9af3694
fix the subsume behavior
torfjelde Jul 29, 2021
e26307f
fixed doctests
torfjelde Jul 29, 2021
fff6f1f
made the construction of the lens for varname a bit nicer
torfjelde Jul 29, 2021
e47abbb
fixed vinds
torfjelde Jul 29, 2021
5328a6b
removed duplicate method
torfjelde Jul 29, 2021
924f45d
make concretize an argument instead of kwarg
torfjelde Jul 29, 2021
79118eb
make concretize an argument instead of kwarg
torfjelde Jul 29, 2021
71af2e4
fixed subsume for lenses
torfjelde Jul 29, 2021
e2ffdad
use using instead of import
torfjelde Jul 29, 2021
638bafc
extend composition rules to varname
torfjelde Jul 29, 2021
b4db7a4
use Setfield.parse_obj_lens and allow begin
torfjelde Jul 31, 2021
8299329
added proper fix for begin in indexing
torfjelde Jul 31, 2021
33d6777
removed a wild StatsBase that had appeared
torfjelde Jul 31, 2021
38ac60a
removed now redundant replace_basesysm
torfjelde Jul 31, 2021
e14ce7c
dont export nonexistent methods
torfjelde Jul 31, 2021
854bbe1
dont allow Tuple in VarName anymore but only allow Lens
torfjelde Jul 31, 2021
f010a1b
sort of fixed _issubrange
torfjelde Jul 31, 2021
253dffe
fixed a doctests
torfjelde Jul 31, 2021
d31461e
added get and set for VarName
torfjelde Aug 1, 2021
b596c11
added backwards compat constructor for VarName
torfjelde Aug 1, 2021
c72faab
added some weird behavior from existing codebase...
torfjelde Aug 1, 2021
fc53f29
no longer need special handling of begin after Setfield 0.7.1
torfjelde Aug 1, 2021
111f805
remove show for old tuple-based VarName
torfjelde Aug 1, 2021
84badce
forgot to check if concretize was true in varname
torfjelde Aug 1, 2021
8c1d193
renamed tuple2indexlens
torfjelde Aug 1, 2021
3a854e2
formatting
torfjelde Aug 1, 2021
2019180
disallow usage of dynamic lenses in VarName
torfjelde Aug 1, 2021
a397bfe
formatting and new show
torfjelde Aug 1, 2021
5905206
updated comment
torfjelde Aug 1, 2021
3f287f5
fixed doctests
torfjelde Aug 17, 2021
b616902
Update Project.toml
yebai Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ version = "0.2.0"

[deps]
AbstractMCMC = "80f14c24-f653-4e6a-9b94-39d6b0f70001"
Setfield = "efcf1570-3423-57d1-acb7-fd33fddbac46"

[compat]
AbstractMCMC = "2, 3"
Setfield = "0.7.1"
julia = "1"
17 changes: 2 additions & 15 deletions src/AbstractPPL.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,11 @@
module AbstractPPL

# VarName
export VarName,
getsym,
getindexing,
inspace,
subsumes,
varname,
vinds,
vsym,
@varname,
@vinds,
@vsym
export VarName, getsym, getindexing, inspace, subsumes, varname, vsym, @varname, @vsym


# Abstract model functions
export AbstractProbabilisticProgram,
condition,
decondition,
logdensity
export AbstractProbabilisticProgram, condition, decondition, logdensity


# Abstract traces
Expand Down
Loading