Fix Race Conditions in Message Verification and User Profile Indexing #2954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2f8b2ea.
islathehut
approved these changes
Aug 7, 2025
adrastaea
added a commit
that referenced
this pull request
Aug 26, 2025
* Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Fix leaveCommunity flow on Android (#2951) * fix cleaning ordering and rn bug with ws over tor listener * fix starter mobile e2e test and add leave community verification * update changelog * update changelog for release * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * bug: fix user profile error persisting after close * Fix Race Conditions in Message Verification and User Profile Indexing (#2954) * debugging statements - to be reverted * retry verification when caching messages or getting user updates * [DEBUG} heads logging - to be removed * update indexes on init * just retry current channel when users update; add unit tests * Revert "debugging statements - to be reverted" This reverts commit 2f8b2ea. * rm retryAll from tests * remove debug logging * fix verifyMessages test * add verification retry triggerd by auth update on channel store in backend as well * e2e test reliability improvement * update changelog * patch: msg validation * Feat/channel debugging tools (#2955) * add channel debugging panel and gate debug panels on development mode * update styling * update changelog * Revert the submodule change in "add channel debugging panel and gate debug panels on development mode" This partially reverts commit 8883dd6. * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * fix tor binary path in locally packaged apps (#2962) * fix tor binary path in locally packaged apps * restore space in path handling * fix windows backend test * use testRegex instead of testMatch * fix: update CHANGELOG.md to include tor binary path detection fix * Fix/mac autoupdater (#2966) * fix tor binary path in locally packaged apps * restore space in path handling * fix windows backend test * use testRegex instead of testMatch * avoiding preventing default actions when updating * restore package version * add fix for automatic updates on mac to changelog * ensure update modal stays on top * fix tests * restore NODE_OPTIONS rm'd during testing * update release manager * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Feat/channels sync retries (#2967) * retry channels syncing when sigchain updates * Improve channel syncing and refactor setChannel method * add test proving that reindexing after auth update works * make test more robust, use custom ipfs access controller on identities, retry joining heads on peer connection * Ensure entry validation runs only on PUTs * update changelog * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * rm type from public-channels db * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md --------- Co-authored-by: Holmes Wilson <[email protected]>
islathehut
added a commit
that referenced
this pull request
Sep 9, 2025
* Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Fix leaveCommunity flow on Android (#2951) * fix cleaning ordering and rn bug with ws over tor listener * fix starter mobile e2e test and add leave community verification * update changelog * update changelog for release * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * bug: fix user profile error persisting after close * Fix Race Conditions in Message Verification and User Profile Indexing (#2954) * debugging statements - to be reverted * retry verification when caching messages or getting user updates * [DEBUG} heads logging - to be removed * update indexes on init * just retry current channel when users update; add unit tests * Revert "debugging statements - to be reverted" This reverts commit 2f8b2ea. * rm retryAll from tests * remove debug logging * fix verifyMessages test * add verification retry triggerd by auth update on channel store in backend as well * e2e test reliability improvement * update changelog * patch: msg validation * Feat/channel debugging tools (#2955) * add channel debugging panel and gate debug panels on development mode * update styling * update changelog * Revert the submodule change in "add channel debugging panel and gate debug panels on development mode" This partially reverts commit 8883dd6. * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * fix tor binary path in locally packaged apps (#2962) * fix tor binary path in locally packaged apps * restore space in path handling * fix windows backend test * use testRegex instead of testMatch * fix: update CHANGELOG.md to include tor binary path detection fix * Fix/mac autoupdater (#2966) * fix tor binary path in locally packaged apps * restore space in path handling * fix windows backend test * use testRegex instead of testMatch * avoiding preventing default actions when updating * restore package version * add fix for automatic updates on mac to changelog * ensure update modal stays on top * fix tests * restore NODE_OPTIONS rm'd during testing * update release manager * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Feat/channels sync retries (#2967) * retry channels syncing when sigchain updates * Improve channel syncing and refactor setChannel method * add test proving that reindexing after auth update works * make test more robust, use custom ipfs access controller on identities, retry joining heads on peer connection * Ensure entry validation runs only on PUTs * update changelog * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * rm type from public-channels db * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Removes cleartext settings in Android app as reported in #2977. (#2978) Creating rooms + uploading images + posting txt messages works fine without this flag. * fix: Keyboard avoiding on android, properly displaying send button on android, newline rendering in message component on mobile (#2980) * Ensure send button shows and fix keyboard hiding input field on android * Accurately render newlines in messages on mobile * Android Changes to Meet Two Upcoming Play Store Deadlines (#2974) * Quiet must target android API 35 (aka "Android 15") in order to have updates deployed onto the playstore. This rule goes into effect on August 31, 2025 See: https://support.google.com/googleplay/android-developer/answer/11926878 Also slightly updated READMEs in desktop and mobile packages * Add guide to using SDKMAN (nvm for JDKs) to mobile README.md This greatly simplifies installing + using the temurin 17 JDK on any UNIX system, especially if you already have a JDK installed. * in mobile README remove confusing Android Studio instruction to open Android Studio that only worked on mac from README, replace with ln command that allows you to open Android Studio however you want and works on mac + linux * in gradle.properties set reactNativeArchitectures to just arm64, currently 32 bit builds were also set here but Quiet only supports 64bit ARM * Changes needed to build with compileSdk 35 - upgrade toolchain version in gradle-wrapper.properties - change NotificationHandler.kt method signature from String? to String to match method signature of new Android API * Update to NDK 28.1.13356709 and bump gradle dependencies that use native code to newer releases to support 16KB page sizes for November 1, 2025 play store restriction Upgrade to android gradle plugin 8.5.1 which is also needed for 16KB pages Bump external gradle deps to newer releaes supporting 16kb alignment * light kotlin + java cleanup * bump react-native-screens from ^3.29.0 to 3.33.0 fixes a crash when compileSdk is 35 and running on a lower android see software-mansion/react-native-screens#2258 * Remove compile warnings form Android manifest, you don't need to set package in here it's ignored, and also useLegacyJni in our gradle overrides this native libs setting * Ran Android Lint after finding #2977 * Update AndroidManifest.xml * Minor fix * Use correct ndk version * Align ndk between ci and gradle --------- Co-authored-by: Isla <[email protected]> * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Add back package name and fix local apk builds (#2983) * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Bring back cleartext as test * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Build standard and debug apks * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Fix debug apk upload * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Update CHANGELOG * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Changelog versions --------- Co-authored-by: Holmes Wilson <[email protected]> Co-authored-by: Taea <[email protected]> Co-authored-by: Taea Vogel <[email protected]> Co-authored-by: bitmold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements event based re-indexing of UserProfileStore and verification of previously unverifiable messages. Solves the issue of messages or user profiles received before the corresponding auth blocks not having a retry mechanism to add them into the state when those blocks are received.
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: