Skip to content

Small fixes and improvements#52

Merged
TrueOsiris merged 8 commits intoTrueOsiris:mainfrom
Diyagi:fixes
May 13, 2024
Merged

Small fixes and improvements#52
TrueOsiris merged 8 commits intoTrueOsiris:mainfrom
Diyagi:fixes

Conversation

@Diyagi
Copy link
Copy Markdown
Contributor

@Diyagi Diyagi commented May 11, 2024

  • Fixes log tail not running
  • Improves shutdown to be more gracefully
  • Silences AVXs grep check
  • Fixes Servername env var check so spaces in the string can work (tho, its not needed tbh, the gameserver itself has its own env vars)
  • Removes the timezone set, tzdata already reads the TZ env and adjusts it accordingly

@dramikei
Copy link
Copy Markdown

Love this change, haven't tested myself but really waiting for a graceful shutdown since I am really paranoid about losing hours worth of save data because of a bad shutdown.

@TrueOsiris pls review when you get time :)

Comment on lines -66 to +84
/usr/bin/tail -f /mnt/vrising/persistentdata/VRisingServer.log
DISPLAY=:0.0 wine64 /mnt/vrising/server/VRisingServer.exe -persistentDataPath $p -serverName "$SERVERNAME" -saveName "$WORLDNAME" -logFile "$p/VRisingServer.log" "$game_port" "$query_port" 2>&1 &

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if its worth it, but can we have logs saved for last 3 runs?

like using VRisingServer-$(date +'%Y%m%d-%H%M').log (example: VRisingServer-20240513-2348.log)

We can maybe cleanup old logs when the script starts. This is helpful in case someone needs to go over old logs after starting a server.

Scenario:

  • User started server
  • Realized that the server didn't exit correctly / Crashed
  • Tries to figure out what happened by going over old logs.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think VRisingServer.log is ever wiped, every time the server starts it seems that it just writes to the end of the file, that said, it would be better if each run had their logs split by files, i will see what i can come up with.

@TrueOsiris
Copy link
Copy Markdown
Owner

TrueOsiris commented May 13, 2024

Hi, could you please explain the following:
Why launch the final line as a child process (&) ?

@TrueOsiris TrueOsiris merged commit aee48fc into TrueOsiris:main May 13, 2024
@Diyagi
Copy link
Copy Markdown
Contributor Author

Diyagi commented May 13, 2024

Hi, could you please explain the following: Why launch the final line as a child process (&) ?

bc if we dont, it will only reach the tail after the gameserver process exits.
Also, the changes to log are missing, i was working on it and i had not commited those yet

@TrueOsiris TrueOsiris added the enhancement New feature or request label May 14, 2024
@dramikei
Copy link
Copy Markdown

Hi, could you please explain the following: Why launch the final line as a child process (&) ?

bc if we dont, it will only reach the tail after the gameserver process exits. Also, the changes to log are missing, i was working on it and i had not committed those yet

@TrueOsiris seems to have implemented logs changes themselves, You can refer the changes in their last commits and suggest changes if you feel like! :)

Thanks for the PR though, running the server on my Dedicated VPS, and its working flawlessly!

dmirtillo pushed a commit to dmirtillo/docker-vrising that referenced this pull request Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants