Migrate core gpu-allocator crate and basic examples to windows-rs
#107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Mar 24, 2022
MarijnS95
commented
Mar 24, 2022
MarijnS95
force-pushed
the
windows-rs
branch
3 times, most recently
from
8f9595d to
6bb9b27
Compare
MarijnS95
force-pushed
the
windows-rs
branch
2 times, most recently
from
35e04bf to
eded1e6
Compare
manon-traverse
approved these changes
May 18, 2022
As has long been planned and discussed we'd like to get rid of the ancient and barely maintained `winapi` crate, in favour of something more modern: `windows-rs` is actively developed and maintained by Microsoft themselves, and generated out of header metadata rather than written by hand. Besides, it provides a more sophisticated and safer API for dealing with objects (abstracting away return types behind `Result`, hiding COM lifetime management, etc). The choice for the "heavier" `windows` crate over `windows-sys` is fairly obvious: DirectX APIs are built on the COM object model which is completely unsupported in `windows-sys` making us unable to perform any method calls. Besides, the `windows-sys` crate does very little to make the API more convenient nor safer to use, effectively taking us a step back from `winapi` instead of a step forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #106
Fixes #62
As has long been planned and discussed we'd like to get rid of the ancient and barely maintained
winapicrate, in favour of something more modern:windows-rsis actively developed and maintained by Microsoft themselves, and generated out of header metadata rather than written by hand. Besides, it provides a more sophisticated and safer API for dealing with objects (abstracting away return types behindResult, hiding COM lifetime management, etc).The choice for the "heavier"
windowscrate overwindows-sysis fairly obvious: DirectX APIs are built on the COM object model which is completely unsupported inwindows-sysmaking us unable to perform any method calls. Besides, thewindows-syscrate does very little to make the API more convenient nor safer to use, effectively taking us a step back fromwinapiinstead of a step forward.