Auto disable error in WarnableTextInputLayout (for space) #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I thought it may be not a good idea to let dialog buttons change their positions... but maybe just because I'm thinking with a web UI's mindset. And from Materials' guideline on Errors, it seems they are also reserving some space for errors without shrinking the spaces when not in use. I'm putting this on hold first. |
Collaborator
Author
Not for simple dialogs (as opposed to full screen dialogs). There's nothing on changing the dialog's height in real time. |
TranceLove
pushed a commit
that referenced
this pull request
Apr 20, 2020
Retrofit naming scheme for storages to older APIs
TranceLove
added a commit
that referenced
this pull request
May 17, 2025
- Fix top right menu Open in Terminal not working - Fix permission granting sequence with PermissionsActivity
TranceLove
added a commit
that referenced
this pull request
May 17, 2025
- Fix top right menu Open in Terminal not working - Fix permission granting sequence with PermissionsActivity
TranceLove
added a commit
that referenced
this pull request
May 17, 2025
- Fix top right menu Open in Terminal not working - Fix permission granting sequence with PermissionsActivity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if you like how it behaves before pulling.