Skip to content

Need to close the handle when there is a cache hit #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TooTallNate merged 3 commits into from
Jul 7, 2025
+6 −0
Merged

Need to close the handle when there is a cache hit #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5713d52
brl-1 Need to close the handle when there is a cache hit
May 9, 2025
192bae1
Create old-beers-melt.md
TooTallNate Jul 7, 2025
deb15c7
Merge branch 'main' into fix-for-leaking-fd
TooTallNate Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/old-beers-melt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"get-uri": patch
---

Close the file descriptor handle when there is a cache hit for `file:` protocol
1 change: 1 addition & 0 deletions packages/get-uri/src/file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ export const file: GetUriProtocol<FileOptions> = async (

// if a `cache` was provided, check if the file has not been modified
if (cache && cache.stat && stat && isNotModified(cache.stat, stat)) {
await fdHandle.close();
throw new NotModifiedError();
}

Expand Down