Skip to content

deleteSelectedData should check self.attributes.editable #587

@marionicolas

Description

@marionicolas

Hi, first of all, have to say this is a remakebly great tool for easy implementing data views.

That said, I´m planning on use it as a core component on a project Im starting and, found out that if I want to control the editing outside the grid like on a modal for example, I can set editable: false, but still a user press on Delete or Backspace results in a row data empty (selectionMode: row).

Checking the code, I found out that beginEditAt has the self.attributes.editable verification builtin, but deleteSelectedData doesnt.
I dont know if this is the only flow that should check for self.attributes.editable, and if this check may wrongly affect other flows.

Is the project active as for attending this issue or should I solve this for myself?

Thanx in advances for every minute invested on this great project.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions