Skip to content

Conversation

@TokisanGames
Copy link
Owner

@TokisanGames TokisanGames commented Jan 28, 2026

Fixes #921
Fixes #931

godotengine/godot#106503 (presumably) broke the asset dock by improperly deprecating the old functions and breaking them, and redesigning new functions.

This PR make a 4.6 compatible asset dock and switches between the new in 4.6+ and old in <=4.5.

Pre 4.5 the editor docks were quite clunky and I wrote a lot of code to handle it's quirks. In 4.6 the system has been redesigned and things that didn't work now do. We no longer need our own dock selector as the built in one finally works properly.

Pending:

  • 4.6 and 4.5 dual compatibility
  • Search filter
  • Search/pin getting icon from editor
  • Pin button missing
  • Verify update_layout() child ordering
  • Instancer Asset icons going too small and crowding buttons
  • Search box too narrow
  • Always on top pin for window mode doesn't work (from pin)
  • Review more code that needs to be removed or adjusted for slot handling or windowing
  • Testing

Cherry-pick for 1.0.2

@TokisanGames TokisanGames added the bug Something isn't working label Feb 3, 2026
@TokisanGames TokisanGames self-assigned this Feb 3, 2026
@TokisanGames TokisanGames moved this to In Progress in Terrain3D Roadmap Feb 3, 2026
@TokisanGames TokisanGames added this to the 1.1 milestone Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

4.6 Issues [4.6] Asset Dock changing Editor Dock Slots broken

2 participants