Fixed uv scale problem in lightweight shader when using the control texture debug view #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the debug view to look at the control texture, I noticed that the control texture didn't match up to the actual terrain/color map after using the newest version of the lightweight shader.
I figured that it's because the uv variable was scaled with _vertex_spacing on line 377, and somehow used for the control texture in the debug_view shader.
I also noticed problems with other debug views, such as the PBR views because the shader expects the material struct (mat).
But maybe the shader is not finished yet, and everyone already knows this, but I thought I would say it here just in case!