Add update_region() for per-region collision updates #905
+48
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| void build(); | ||
| void reset_target_position() { _last_snapped_pos = V2I_MAX; } | ||
| void update(const bool p_rebuild = false); | ||
| void update_region(const Vector2i &p_region_loc); |
Owner
There was a problem hiding this comment.
Like our other update functions, this location selection should be incorporated into update().
https://github.com/TokisanGames/Terrain3D/blob/main/src/terrain_3d_instancer.h#L97
https://github.com/TokisanGames/Terrain3D/blob/main/src/terrain_3d_data.h#L134
Then it should be able to reuse code in the same function.
It should have a location parameter that defaults to V2I_MAX to indicate all regions.
Contributor
Author
There was a problem hiding this comment.
Your right, similar to the update_maps overload for the visual terrain, I should do an implementation/integration for the update function that already exist. When I get the chance Ill restructure it
|
This would be super useful! Hard agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #891
Adds
update_region()method to update collision for a single region instead of rebuilding all regions.Currently, runtime terrain modification (craters, explosions, deformation) requires calling
update()which rebuilds collision for every region. This is expensive for large terrains.New method
Terrain3DCollision::update_region(region_loc: Vector2i)updates only the specified region's collision shape.Usage