MessageUtils#extractCode out of bounds #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
SquidXTV
approved these changes
Feb 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes and closes #766 .
Its about a bug in the logic for
MessageUtils#extractCode, happens when the "end of the code" (indicated by 3 backticks) is before the end of the "language tag", i.e. likejava.Essentially, the closing code block should be found after the language tag, so
indexOf(3 backticks, languageEnd)instead of at the start of it.So I just moved the part down and now it works. Also added unit tests.
Details
As an example, consider the following message:
Blue should only start after green, not before.
So the new order is: