Features/add command to reset activity for a help thread #739

CodePawfect · 2023-01-01T11:11:45Z

Description

closes #567 This pull request modifies the HelpThreadActivityUpdater class. The changes include:

Adding a Cache field that stores the message ID of the most recent message in a thread channel when reset-activity command is triggered.
Modifying the updateActivityForThread method to use the cache to determine the activity level of a thread if existing.

Performance

How are entries in the cache deleted?
Entries in the cache are deleted in two ways:

If someone closes a thread with the close command, the channel that is the key in the cache entry is removed.
An entry in the cache is automatically removed after 12 hours. I think this should be enough, but it can be increased if needed.

Tests

add HelpThreadResetHelpActivityCommand class;

...ation/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadResetActivityCommand.java

application/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadCommand.java

i missed something

application/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadCommand.java

application/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadActivityUpdater.java

application/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadCommand.java

application/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadActivityUpdater.java

PR #739

application/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadActivityUpdater.java

PR #739

application/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadActivityUpdater.java

PR #739

application/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadCommand.java

changed description text for reset activity command PR #739

Zabuzard

Good stuff

CodePawfect added 3 commits December 30, 2022 18:06

add HelpThreadHistoryCache class;

dc1fd1a

add HelpThreadResetHelpActivityCommand class;

Implement feature #567: Add command to reset activity for a help thread

7072821

change access modifier back to private and class back to final;

3f2a7c2

CodePawfect requested review from a team as code owners January 1, 2023 11:11

CodePawfect marked this pull request as draft January 1, 2023 11:13

Taz03 requested changes Jan 1, 2023

View reviewed changes

...ation/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadResetActivityCommand.java Outdated Show resolved Hide resolved

CodePawfect added 6 commits January 1, 2023 18:13

changed ResetActivityCommand from own command to Subcommand;

07dfec7

add removeChannel method to cache; adjust methods;

9ae5835

replaced HelpThreadManuallyResetHistoryCache.java with Caffeine Object.

3aefdbe

adjust cache setting and variable name;

e2464bf

changes command response message;

49d15a4

changed access modifier to package-private; adjust resetActivity;

0ef8cb3

CodePawfect requested a review from Taz03 January 3, 2023 10:47

CodePawfect marked this pull request as ready for review January 3, 2023 12:01

CodePawfect linked an issue Jan 3, 2023 that may be closed by this pull request

Add command to reset activity for a help thread #567

Closed

CodePawfect added enhancement New feature or request priority: major new command Add a new command or group of commands to the bot labels Jan 3, 2023

CodePawfect self-assigned this Jan 3, 2023

Taz03 requested changes Jan 3, 2023

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadCommand.java Outdated Show resolved Hide resolved

changed suggestions from code findings;

8e61a4f

CodePawfect requested a review from Taz03 January 3, 2023 14:25

CodePawfect marked this pull request as draft January 4, 2023 09:02

CodePawfect added 2 commits January 5, 2023 18:37

removed not needed sorting;

ca4f636

adjust line formatting;

ba631e6

CodePawfect marked this pull request as ready for review January 5, 2023 17:38

CodePawfect added 2 commits January 5, 2023 19:39

added if case that only thread author can reset activity;

3625a00

added if case that only thread author can reset activity;

485e277

Taz03 requested changes Jan 5, 2023

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadCommand.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadCommand.java Outdated Show resolved Hide resolved

changed blocking to async method;

d5aaff7

CodePawfect requested a review from Taz03 January 5, 2023 21:36

add return;

d03a114

Taz03 requested changes Jan 5, 2023

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadCommand.java Outdated Show resolved Hide resolved

removed lines from lambda;

b2d6ae7

CodePawfect requested a review from Taz03 January 6, 2023 04:23

Taz03 previously approved these changes Jan 6, 2023

View reviewed changes

Taz03 requested changes Jan 6, 2023

View reviewed changes

changed cache type

142e20d

CodePawfect requested a review from Taz03 January 6, 2023 09:16

changed getId to getIdLong and removed line;

d96edac

Taz03 previously approved these changes Jan 6, 2023

View reviewed changes

Zabuzard requested changes Jan 9, 2023

View reviewed changes

resolved code findings;

e2d7d3a

PR #739

CodePawfect dismissed Taz03’s stale review via e2d7d3a January 9, 2023 18:52

Taz03 requested changes Jan 9, 2023

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadActivityUpdater.java Outdated Show resolved Hide resolved

resolved code findings #2;

dd339a8

PR #739

Zabuzard requested changes Jan 10, 2023

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadActivityUpdater.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadActivityUpdater.java Outdated Show resolved Hide resolved

resolved code findings #3;

ae2d562

PR #739

CodePawfect requested review from Taz03 and Zabuzard January 13, 2023 13:56

Zabuzard requested changes Jan 16, 2023

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadCommand.java Outdated Show resolved Hide resolved

resolved code findings #4;

895d487

changed description text for reset activity command PR #739

CodePawfect requested a review from Zabuzard January 18, 2023 18:11

Zabuzard approved these changes Jan 20, 2023

View reviewed changes

Taz03 approved these changes Jan 20, 2023

View reviewed changes

CodePawfect merged commit 32b0acb into Together-Java:develop Jan 20, 2023

CodePawfect deleted the features/add-command-to-reset-activity-for-a-help-thread branch January 20, 2023 08:48

Zabuzard mentioned this pull request Feb 7, 2023

Release v4.3 #764

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Features/add command to reset activity for a help thread #739

Features/add command to reset activity for a help thread #739

Uh oh!

CodePawfect commented Jan 1, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Zabuzard left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Features/add command to reset activity for a help thread #739

Features/add command to reset activity for a help thread #739

Uh oh!

Conversation

CodePawfect commented Jan 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Performance

Tests

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Zabuzard left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CodePawfect commented Jan 1, 2023 •

edited

Loading