Skip to content

Enhanced mod action dm message #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Zabuzard merged 10 commits into from
Feb 7, 2023
Merged

Enhanced mod action dm message #647

Zabuzard merged 10 commits into from
Feb 7, 2023

Conversation

@Taz03
Copy link
Member

@Taz03 Taz03 commented Oct 21, 2022 •
edited
Loading

closes #620

image

todo:

  • use embed in dm message
  • use better colors
  • remove details on how to contact mod in non punishing actions

@Taz03 Taz03 added enhance command Modify or improve an existing command or group of commands of the bot priority: normal labels Oct 21, 2022
@Taz03 Taz03 self-assigned this Oct 21, 2022
@Taz03 Taz03 marked this pull request as ready for review October 22, 2022 07:01
@Taz03 Taz03 requested review from a team as code owners October 22, 2022 07:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Zabuzard
Zabuzard requested changes Oct 24, 2022
View reviewed changes
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please restore the original text for all messages. u made the messages less friendly and some of them also sound a bit weird now.

just dont touch them, leave it as it is. just wrap embed around and thats it 🙂

@Taz03
Copy link
Member Author

Taz03 commented Dec 3, 2022

if anyone want they can take over this pr

@github-actions
Copy link

github-actions bot commented Jan 12, 2023

This pull request is stale because it has been open 30 days with no activity. Remove stale label, comment or add the valid label or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Jan 12, 2023
@Taz03
Copy link
Member Author

Taz03 commented Jan 12, 2023

image
@Zabuzard

@Taz03 Taz03 requested a review from Zabuzard January 12, 2023 08:57
@Zabuzard
Copy link
Member

Zabuzard commented Jan 12, 2023

What about:

  • unmute
  • unban
  • kick
  • quarantine
  • unquarantine
  • warn

Your example covers:

  • ban
  • mute

Also, you suggest them in ban to use /modmail, but that doesnt work. /modmail can only be used if you are still in the server. So its not an option for ban and kick. (which is why the old messages dont suggest it for them)

@Taz03
Copy link
Member Author

Taz03 commented Jan 12, 2023

it also covers unmute btw, will send others as well

@Zabuzard
Copy link
Member

Zabuzard commented Jan 12, 2023

ah. for unmute, you are missing the smiley "👌 "

@github-actions github-actions bot added valid This issue/PR is validated and ready to be picked. This auto adds items to TJ project board. and removed stale labels Jan 13, 2023
@Taz03
Copy link
Member Author

Taz03 commented Jan 22, 2023 •
edited
Loading

Old vs New comparison

Warn
image
image

Quarantine
image
image

Unquarantine
image
image

Mute
image
image

Unmute
image
image

Kick
image
image

Ban
image
image

@Taz03
Copy link
Member Author

Taz03 commented Jan 22, 2023

@Zabuzard

@Zabuzard
Copy link
Member

Zabuzard commented Jan 23, 2023

Thanks for the comparisons. Now please adjust the code to spit out the same messages and then Im happy.

  • ban/kick: dont suggest /modmail
  • kick: missing "from the server.", missing "If you think this was a mistake, ..."
  • ban: missing "If you think this was a mistake, ..."
  • unmute: missing 👌
  • mute: missing "you can simply use /modmail here in this chat. Your message ...😊"
  • unquarantine: missing 👌
  • quarantine: missing "you can simply use /modmail here in this chat. Your message ...😊"
  • warn: missing "you can simply use /modmail here in this chat. Your message ... 😊"

@Taz03
Copy link
Member Author

Taz03 commented Jan 27, 2023

@Zabuzard done

Zabuzard
Zabuzard requested changes Jan 30, 2023
View reviewed changes
@Taz03 Taz03 requested a review from Zabuzard January 30, 2023 12:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Taz03
Copy link
Member Author

Taz03 commented Feb 6, 2023

@Zabuzard 1 week passed with no other review, merge now?

@Zabuzard Zabuzard merged commit 8dc3b07 into develop Feb 7, 2023
@Zabuzard Zabuzard deleted the feature/mod-action-dm branch February 7, 2023 08:38
@Zabuzard Zabuzard mentioned this pull request Feb 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zabuzard Zabuzard Zabuzard approved these changes

Assignees

@Taz03 Taz03

Labels

enhance command Modify or improve an existing command or group of commands of the bot priority: normal valid This issue/PR is validated and ready to be picked. This auto adds items to TJ project board.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve formatting on user facing moderation messages

3 participants

@Taz03 @Zabuzard